Bug 94449 – [TouchAdjustment] Adjust to word or selection

• Status: RESOLVED
• Resolution: FIXED
• Component: UI Events

[Allan Sandfeld Jensen]

The context-menu gesture is currently not adjusting as good as it could, to the nearest word, or the active selection.

[Allan Sandfeld Jensen]

Created attachment 159350 [details]
Patch

[Allan Sandfeld Jensen]

Comment on attachment 159350 [details]
Patch

Needs a test-case before landing.

[WebKit Review Bot]

Comment on attachment 159350 [details]
Patch

Attachment 159350 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13529890

New failing tests:
touchadjustment/context-menu-select-text.html

[WebKit Review Bot]

Created attachment 159378 [details]
Archive of layout-test-results from gce-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-03  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Allan Sandfeld Jensen]

Created attachment 159381 [details]
Patch

Added test, and fixed the word-iteration

[WebKit Review Bot]

Comment on attachment 159381 [details]
Patch

Clearing flags on attachment: 159381

Committed r126026: <http://trac.webkit.org/changeset/126026>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Kenneth Russell]

This patch caused assertion failures inside WebCore::TouchAdjustment::appendContextSubtargetsForNode(WebCore::Node*, WebCore::TouchAdjustment::SubtargetGeometryList&):

crash log for DumpRenderTree (pid 26367):
STDOUT: <empty>
STDERR: ASSERTION FAILED: textRenderer->selectionState() != RenderObject::SelectionNone
STDERR: third_party/WebKit/Source/WebCore/page/TouchAdjustment.cpp(168) : void WebCore::TouchAdjustment::appendContextSubtargetsForNode(WebCore::Node*, WebCore::TouchAdjustment::SubtargetGeometryList&)
STDERR: 1   0x7f634be7a329
STDERR: 2   0x7f634be7a9a9
STDERR: 3   0x7f634be7ba10
STDERR: 4   0x7f634be0cb15
STDERR: 5   0x7f634aec1bbb
STDERR: 6   0x7f634aed42d9
STDERR: 7   0x7f63483d46f4
STDERR: 8   0x7f63483cf50d
STDERR: 9   0x7f63483cf4de
STDERR: 10  0x28b7ece0618e
STDERR: [26367:26367:12957102334383:ERROR:process_util_posix.cc(143)] Received signal 11
STDERR: 	base::debug::StackTrace::StackTrace() [0x7f6347f58ea6]
STDERR: 	base::(anonymous namespace)::StackDumpSignalHandler() [0x7f6347fbfffd]
STDERR: 	0x7f6341c4aaf0
STDERR: 	WebCore::TouchAdjustment::appendContextSubtargetsForNode() [0x7f634be7a333]
STDERR: 	WebCore::TouchAdjustment::compileSubtargetList() [0x7f634be7a9a9]
STDERR: 	WebCore::findBestContextMenuCandidate() [0x7f634be7ba10]
STDERR: 	WebCore::EventHandler::bestContextMenuNodeForTouchPoint() [0x7f634be0cb15]
STDERR: 	WebCore::Internals::touchNodeAdjustedToBestContextMenuNode() [0x7f634aec1bbb]
STDERR: 	WebCore::InternalsV8Internal::touchNodeAdjustedToBestContextMenuNodeCallback() [0x7f634aed42d9]
STDERR: 	v8::internal::HandleApiCallHelper<>() [0x7f63483d46f4]
STDERR: 	v8::internal::Builtin_Impl_HandleApiCall() [0x7f63483cf50d]
STDERR: 	v8::internal::Builtin_HandleApiCall() [0x7f63483cf4de]
STDERR: 	0x28b7ece0618e

See:

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=touchadjustment%2Fcontext-menu.html

I'm inclined to roll out this patch because this may actually be a real problem with the code. Will try to contact the author or reviewer on IRC first.

[Kenneth Russell]

Pinged tonikitoo on IRC about this but wasn't able to reach carewolf. I'm rolling out this patch because of potentially real problems in the code -- suppressing the assertion failure in TestExpectations seems like a bad idea.

[Kenneth Russell]

Reverted r126026 for reason:

Caused assertion failure in layout test touchadjustment/context-menu.html

Committed r126069: <http://trac.webkit.org/changeset/126069>

[Allan Sandfeld Jensen]

The assertion is wrong, and the case asserted was actually handled in the final patch. I will remove the wrong assertion in a new version of the patch.

[Allan Sandfeld Jensen]

Created attachment 159888 [details]
Patch

[WebKit Review Bot]

Comment on attachment 159888 [details]
Patch

Clearing flags on attachment: 159888

Committed r126284: <http://trac.webkit.org/changeset/126284>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.