RESOLVED FIXED 94446
[V8] Move contextDebugId() and setContextDebugId() from V8Proxy to ScriptController 
https://bugs.webkit.org/show_bug.cgi?id=94446
Summary [V8] Move contextDebugId() and setContextDebugId() from V8Proxy to ScriptCont...
Kentaro Hara
Reported 2012-08-19 23:03:36 PDT
To kill V8Proxy, we can move contextDebugId() and setContextDebugId() from V8Proxy to ScriptController.
Attachments
Patch (7.87 KB, patch)
2012-08-19 23:14 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-19 23:14:06 PDT
Created attachment 159338 [details] Patch
Adam Barth
Comment 2 2012-08-19 23:28:40 PDT
Comment on attachment 159338 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159338&action=review This code is kind of nuts. > Source/WebCore/bindings/v8/ScriptController.cpp:532 > + char buffer[32]; > + snprintf(buffer, sizeof(buffer), "page,%d", debugId); Can you add buffer[31] = '\0' ? > Source/WebCore/bindings/v8/V8IsolatedContext.cpp:85 > // Setup context id for JS debugger. I'd remove this comment.
Kentaro Hara
Comment 3 2012-08-20 00:53:53 PDT
Committed r126005: <http://trac.webkit.org/changeset/126005>
Kentaro Hara
Comment 4 2012-08-20 00:54:29 PDT
(In reply to comment #2) > Can you add buffer[31] = '\0' ? > > > Source/WebCore/bindings/v8/V8IsolatedContext.cpp:85 > > // Setup context id for JS debugger. > > I'd remove this comment. Done. Thanks!
Note You need to log in before you can comment on or make changes to this bug.