RESOLVED FIXED Bug 94443
[V8] Move V8Proxy::newInstance() to V8ObjectConstructor 
https://bugs.webkit.org/show_bug.cgi?id=94443
Summary [V8] Move V8Proxy::newInstance() to V8ObjectConstructor
Kentaro Hara
Reported 2012-08-19 21:56:08 PDT
To kill V8Proxy, we can move V8Proxy::newInstance() to V8ObjectConstructor.
Attachments
Patch (10.83 KB, patch)
2012-08-19 22:15 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Patch (10.83 KB, patch)
2012-08-19 22:23 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
patch for landing (10.84 KB, patch)
2012-08-19 23:21 PDT, Kentaro Hara 		haraken: commit-queue-
DetailsFormatted DiffDiff
patch for landing (10.85 KB, patch)
2012-08-19 23:52 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-19 22:15:31 PDT
Created attachment 159331 [details] Patch
Kentaro Hara
Comment 2 2012-08-19 22:23:51 PDT
Created attachment 159332 [details] Patch
Adam Barth
Comment 3 2012-08-19 23:02:26 PDT
Comment on attachment 159332 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159332&action=review > Source/WebCore/bindings/v8/V8Binding.cpp:384 > +void assertIfV8IsDead() assertIfV8IsDead -> crashIfV8IsDead This happens in release too, so it shouldn't say "alert" > Source/WebCore/bindings/v8/V8ObjectConstructor.cpp:71 > +v8::Local<v8::Object> V8ObjectConstructor::newInstanceInFrame(v8::Handle<v8::Function> function, int argc, v8::Handle<v8::Value> argv[], Frame* frame) Can we pass in a Document rather than a Frame here? Using a Frame for a context object isn't correct.
Kentaro Hara
Comment 4 2012-08-19 23:21:56 PDT
Created attachment 159339 [details] patch for landing
Kentaro Hara
Comment 5 2012-08-19 23:22:48 PDT
(In reply to comment #3) > assertIfV8IsDead -> crashIfV8IsDead > > > +v8::Local<v8::Object> V8ObjectConstructor::newInstanceInFrame(v8::Handle<v8::Function> function, int argc, v8::Handle<v8::Value> argv[], Frame* frame) > > Can we pass in a Document rather than a Frame here? Using a Frame for a context object isn't correct. Done. Thanks for review.
Kentaro Hara
Comment 6 2012-08-19 23:52:26 PDT
Created attachment 159345 [details] patch for landing
WebKit Review Bot
Comment 7 2012-08-20 00:47:43 PDT
Comment on attachment 159345 [details] patch for landing Clearing flags on attachment: 159345 Committed r126004: <http://trac.webkit.org/changeset/126004>
Note You need to log in before you can comment on or make changes to this bug.