Bug 94439 - [Tests] time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html are failed on Chromium Mac
Summary: [Tests] time-multiple-fields-appearance-basic.html and time-multiple-fields-a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on: 95055
Blocks:
  Show dependency tree / graph
 
Reported: 2012-08-19 18:27 PDT by yosin
Modified: 2012-08-28 19:28 PDT (History)
5 users (show)

See Also:

Attachments
Patch 1 (163.47 KB, patch)
2012-08-19 21:25 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 2 (163.47 KB, patch)
2012-08-19 21:49 PDT, yosin 		no flags Details | Formatted Diff | Diff
Patch 3 (163.47 KB, patch)
2012-08-19 21:52 PDT, yosin 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-08-19 18:27:34 PDT 
Chromium Mac port failed on time-multiple-fields-appearance-basic.html and time-multiple-fields-appearance-pseudo-elements.html.
It seems this failure is caused by CSS selector difference in Chromium Mac port.
Comment 1 yosin 2012-08-19 21:25:21 PDT 
Created attachment 159325 [details]
Patch 1
Comment 2 yosin 2012-08-19 21:26:08 PDT 
Comment on attachment 159325 [details]
Patch 1

Could you review this patch?
Thanks in advance.
Comment 3 Kent Tamura 2012-08-19 21:35:04 PDT 
Comment on attachment 159325 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=159325&action=review

> LayoutTests/ChangeLog:13
> +        (.host): Changed padding select.

'padding' is not a selector.  It's a CSS property.

> LayoutTests/ChangeLog:14
> +        (.ampmField): Remove wrong selector.

ditto.
Comment 4 yosin 2012-08-19 21:49:14 PDT 
Created attachment 159327 [details]
Patch 2
Comment 5 yosin 2012-08-19 21:52:03 PDT 
Created attachment 159328 [details]
Patch 3
Comment 6 yosin 2012-08-19 21:53:11 PDT 
Comment on attachment 159328 [details]
Patch 3

Clearing flags on attachment: 159328

Committed r125996: <http://trac.webkit.org/changeset/125996>
Comment 7 yosin 2012-08-19 21:53:18 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 yosin 2012-08-20 00:40:14 PDT 
Spin button elements are still different...
Comment 9 yosin 2012-08-28 19:28:57 PDT 
I did rebaseline (http://trac.webkit.org/changeset/126843)