Bug 94438 - [V8] Move m_windowShell from V8Proxy to ScriptController
Summary: [V8] Move m_windowShell from V8Proxy to ScriptController
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Blocks: 85330
  Show dependency treegraph
Reported: 2012-08-19 18:15 PDT by Kentaro Hara
Modified: 2012-08-19 21:32 PDT (History)
4 users (show)

See Also:

Patch (6.46 KB, patch)
2012-08-19 18:44 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-08-19 18:15:05 PDT
m_windowShell should be owned by ScriptController.

After this change, I can move a bunch of V8Proxy methods that access windowShell() from V8Proxy to ScriptController.
Comment 1 Kentaro Hara 2012-08-19 18:44:55 PDT
Created attachment 159316 [details]
Comment 2 Adam Barth 2012-08-19 20:46:09 PDT
Comment on attachment 159316 [details]

I thought I tried this before and there was some complication, but perhaps that complication has been removed.  This patch certainly look straightforward and correct.

Note: We eventually want ScriptController to hold a map from DOMWrapperWorld to V8WindowShell, but that's a separate effort.
Comment 3 Adam Barth 2012-08-19 20:48:32 PDT
@dcarney: Related to your work with making a WindowShell per DOMWrapperWorld.
Comment 4 WebKit Review Bot 2012-08-19 21:32:30 PDT
Comment on attachment 159316 [details]

Clearing flags on attachment: 159316

Committed r125993: <http://trac.webkit.org/changeset/125993>
Comment 5 WebKit Review Bot 2012-08-19 21:32:34 PDT
All reviewed patches have been landed.  Closing bug.