Bug 94437 - [V8] Move V8Proxy::callFunction() to ScriptController
Summary: [V8] Move V8Proxy::callFunction() to ScriptController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 85330
  Show dependency tree / graph
 
Reported: 2012-08-19 17:47 PDT by Kentaro Hara
Modified: 2012-08-19 22:19 PDT (History)
5 users (show)

See Also:

Attachments
Patch (13.32 KB, patch)
2012-08-19 17:55 PDT, Kentaro Hara 		peter+ews: commit-queue-
Details | Formatted Diff | Diff
patch for landing (13.32 KB, patch)
2012-08-19 21:28 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-08-19 17:47:37 PDT 
To kill V8Proxy, we can move callFunction() from V8Proxy to ScriptController.
Comment 1 Kentaro Hara 2012-08-19 17:55:04 PDT 
Created attachment 159312 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-19 17:58:26 PDT 
Attachment 159312 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/bindings/v8/ScheduledAction.h:43:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Peter Beverloo (cr-android ews) 2012-08-19 18:15:21 PDT 
Comment on attachment 159312 [details]
Patch

Attachment 159312 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13535572
Comment 4 Adam Barth 2012-08-19 20:43:51 PDT 
I'm not sure why this patch fails on Android.  Please make sure it builds before landing.  ;)
Comment 5 Kentaro Hara 2012-08-19 21:28:33 PDT 
Created attachment 159326 [details]
patch for landing
Comment 6 Kentaro Hara 2012-08-19 21:30:30 PDT 
(In reply to comment #4)
> I'm not sure why this patch fails on Android.  Please make sure it builds before landing.  ;)

Wrong: ASSERT(script->proxy)
Correct: ASSERT(script->proxy())

cr-linux is build in the Release mode, and thus ASSERT() is ignored. android is build in the Debug mode, and thus ASSERT() is not ignored. Thanks.
Comment 7 WebKit Review Bot 2012-08-19 21:31:40 PDT 
Attachment 159326 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/bindings/v8/ScheduledAction.h:43:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Adam Barth 2012-08-19 21:40:37 PDT 
That's handy.  Thanks for setting up the cr-android bot to build debug.
Comment 9 Kentaro Hara 2012-08-19 22:19:21 PDT 
Committed r125998: <http://trac.webkit.org/changeset/125998>