Bug 94423 – Web Inspector: prepare scripts panel to be lazily loaded

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

- makes scripts panel read workspace data upon creation
- moves pause on script state management into the debugger model
- updates frontend API to use debugger model, not scripts panel

[Pavel Feldman]

Created attachment 159287 [details]
Patch

[WebKit Review Bot]

Comment on attachment 159287 [details]
Patch

Attachment 159287 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13535380

New failing tests:
http/tests/inspector/network/script-as-text-loading.html
http/tests/inspector/network/network-content-replacement-xhr.html
http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html
http/tests/inspector/network/network-xhr-async-double.html
http/tests/inspector/console-resource-errors.html
http/tests/inspector/network/network-disable-cache-xhrs.html
http/tests/inspector/console-cross-origin-iframe-logging.html
http/tests/inspector-enabled/contentSecurityPolicy-blocks-setTimeout.html
http/tests/inspector/indexeddb/database-structure.html
http/tests/inspector/network/network-disable-cache-memory.html
http/tests/inspector/network/network-xhr-async.html
http/tests/inspector/network/network-request-revision-content.html
http/tests/inspector/indexeddb/resources-panel.html
http/tests/inspector/network/network-xhr-same-url-as-main-resource.html
http/tests/inspector/network/network-cachedresources-with-same-urls.html
http/tests/inspector/network/async-xhr-json-mime-type.html
http/tests/inspector/appcache/appcache-swap.html
http/tests/inspector/network/network-iframe-load-and-delete.html
http/tests/inspector/network/network-sidebar-width.html
http/tests/inspector/network/network-image-404.html
http/tests/inspector/indexeddb/database-names.html
http/tests/inspector/network/network-disabling-check-no-memory-leak.html
http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html
http/tests/inspector/console-xhr-logging.html
http/tests/inspector/network/network-empty-xhr.html
http/tests/inspector/network/network-xhr-sync.html
http/tests/inspector-enabled/contentSecurityPolicy-blocks-setInterval.html
http/tests/inspector/network/network-cyrillic-xhr.html

[WebKit Review Bot]

Created attachment 159289 [details]
Archive of layout-test-results from gce-cr-linux-05

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-05  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid

[Pavel Feldman]

Created attachment 159293 [details]
Patch

[Vsevolod Vlasov]

Comment on attachment 159293 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159293&action=review

Scipts panel should check if debugger is paused on creation.

> Source/WebCore/inspector/front-end/ScriptsPanel.js:313
> +            if (!(uiSourceCodes[i] instanceof WebInspector.JavaScriptSource))

Looks like a hack. I don't think this will work correctly with snippets.

[Pavel Feldman]

Created attachment 159370 [details]
Patch

[Pavel Feldman]

Committed r126009: <http://trac.webkit.org/changeset/126009>