Bug 94422 - Web Inspector: toolbar causes 8 reflows upon opening
Summary: Web Inspector: toolbar causes 8 reflows upon opening
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2012-08-18 22:31 PDT by Pavel Feldman
Modified: 2012-08-20 00:21 PDT (History)
11 users (show)

See Also:

Patch (8.30 KB, patch)
2012-08-18 22:54 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-08-18 22:31:32 PDT
Toolbar's overflow code causes inspector for do 8 reflows upon opening. Fixing it via introducing batch toolbar updates.
Comment 1 Pavel Feldman 2012-08-18 22:54:41 PDT
Created attachment 159281 [details]
Comment 2 Yury Semikhatsky 2012-08-19 23:27:46 PDT
Comment on attachment 159281 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=159281&action=review

> Source/WebCore/inspector/front-end/Toolbar.js:55
> +        if (!this._coalescingLevel)

No need to check it here.

> Source/WebCore/inspector/front-end/inspector.js:519
> +    this.toolbar.setCoalescingUpdate(true);

Consider changing addPanel() to addPanels() that would encapsulate this optimization for batch mode or pass the batchMode flag as an explicit parameter to addPanel.
Comment 3 WebKit Review Bot 2012-08-20 00:21:32 PDT
Comment on attachment 159281 [details]

Clearing flags on attachment: 159281

Committed r126001: <http://trac.webkit.org/changeset/126001>
Comment 4 WebKit Review Bot 2012-08-20 00:21:36 PDT
All reviewed patches have been landed.  Closing bug.