Hyatt wants something like overflow-style implemented in WebKit (read about overflow-style here: http://dev.w3.org/csswg/css3-gcpm/#paged-presentations ), but as new values on overflow-y instead of a new property named overflow-style. <rdar://problem/11831783> I have a patch that gets a lot of this done, and I will post it soon to get feedback.
Created attachment 159247 [details] Patch for feedback
Comment on attachment 159247 [details] Patch for feedback View in context: https://bugs.webkit.org/attachment.cgi?id=159247&action=review Everything looks good. As also mentioned, when dealing with overflow areas, the content width is what you want to use to set up the column width. > Source/WebCore/css/CSSParser.cpp:1776 > + overflowXValue = cssValuePool().createIdentifierValue(CSSValueHidden); As discussed, for now, let's make this default to auto for paged-x and hidden for paged-y. > Source/WebCore/page/FrameView.cpp:159 > + // is horizontal, then the direction of the horizontality dictates the choice. If the WritingMode It is fantastic that you managed to work "horizontality" into a comment. What a great word! :)
Created attachment 159572 [details] Patch
Attachment 159572 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/WebCore/rendering/Pagination.h:26: #ifndef header guard has wrong style, please use: Pagination_h [build/header_guard] [5] Total errors found: 1 in 38 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 159576 [details] Patch for style bot
Created attachment 159582 [details] Attempt to get other ports building
Comment on attachment 159582 [details] Attempt to get other ports building Attachment 159582 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13538883
Comment on attachment 159582 [details] Attempt to get other ports building Attachment 159582 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13549192 New failing tests: fast/overflow/paged-y-div.html fast/overflow/paged-y-on-root.html fast/overflow/paged-x-on-root.html fast/overflow/paged-x-div.html
Created attachment 159594 [details] Archive of layout-test-results from gce-cr-linux-08 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-08 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment on attachment 159582 [details] Attempt to get other ports building Attachment 159582 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13547493
Created attachment 159727 [details] Will it build, v2
Comment on attachment 159727 [details] Will it build, v2 Attachment 159727 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13550496
Comment on attachment 159727 [details] Will it build, v2 Attachment 159727 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13550518 New failing tests: fast/overflow/paged-y-div.html fast/overflow/paged-y-on-root.html fast/overflow/paged-x-on-root.html fast/overflow/paged-x-div.html
Created attachment 159761 [details] Archive of layout-test-results from gce-cr-linux-06 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Created attachment 159762 [details] Will it build, v3 Okay, I am optimistic about this one for GTK.
Comment on attachment 159762 [details] Will it build, v3 Attachment 159762 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13564012 New failing tests: fast/overflow/paged-y-div.html fast/overflow/paged-y-on-root.html fast/overflow/paged-x-on-root.html fast/overflow/paged-x-div.html
Created attachment 159774 [details] Archive of layout-test-results from gce-cr-linux-07 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment on attachment 159762 [details] Will it build, v3 Attachment 159762 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13561016
Created attachment 159783 [details] Will it build, v4
Attachment 159783 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1 Source/WebCore/rendering/RenderView.cpp:229: Missing space after , [whitespace/comma] [3] Total errors found: 1 in 43 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 159787 [details] Without printfs this time
Comment on attachment 159787 [details] Without printfs this time Attachment 159787 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13557084
Created attachment 159808 [details] Will it build, v5
It's time to go HAM on these builders.
Comment on attachment 159808 [details] Will it build, v5 Attachment 159808 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13566133 New failing tests: fast/overflow/paged-y-div.html fast/overflow/paged-y-on-root.html fast/overflow/paged-x-on-root.html fast/overflow/paged-x-div.html
Created attachment 159861 [details] Archive of layout-test-results from gce-cr-linux-07 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
(In reply to comment #26) > Created an attachment (id=159861) [details] > Archive of layout-test-results from gce-cr-linux-07 > > The attached test failures were seen while running run-webkit-tests on the chromium-ews. > Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid I think Chromium-specific test results are in order here. It just seems like small pixel differences that come down to platform differences.
(In reply to comment #27) > (In reply to comment #26) > > Created an attachment (id=159861) [details] [details] > > Archive of layout-test-results from gce-cr-linux-07 > > > > The attached test failures were seen while running run-webkit-tests on the chromium-ews. > > Bot: gce-cr-linux-07 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid > > I think Chromium-specific test results are in order here. It just seems like small pixel differences that come down to platform differences. I wonder if these results should go in the chromium directory or the chromium-linux directory?
Comment on attachment 159808 [details] Will it build, v5 r=me
Thanks, Dave! Committed change with http://trac.webkit.org/changeset/126343 I didn't check in the new chromium expectations because I wasn't sure whether to put them in chromium or chromium-linux.