RESOLVED FIXED 94392
[chromium] Put webkit compositor binding files in separate conditionally included gyp section 
https://bugs.webkit.org/show_bug.cgi?id=94392
Summary [chromium] Put webkit compositor binding files in separate conditionally incl...
James Robinson
Reported 2012-08-17 16:16:29 PDT
[chromium] Put webkit compositor binding files in separate conditionally included gyp section
Attachments
Patch (7.35 KB, patch)
2012-08-17 16:17 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (7.87 KB, patch)
2012-08-17 17:23 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Patch (7.88 KB, patch)
2012-08-17 18:06 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-08-17 16:17:14 PDT
Created attachment 159224 [details] Patch
James Robinson
Comment 2 2012-08-17 16:18:04 PDT
We unconditionally pull 'webkit/' from the chromium repo, so a separate DEPS entry isn't needed for webkit/compositor/
WebKit Review Bot
Comment 3 2012-08-17 16:34:42 PDT
Comment on attachment 159224 [details] Patch Attachment 159224 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13514999
Peter Beverloo (cr-android ews)
Comment 4 2012-08-17 16:39:16 PDT
Comment on attachment 159224 [details] Patch Attachment 159224 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13533071
James Robinson
Comment 5 2012-08-17 17:08:35 PDT
Hmm, I thought that gyp var would have been picked up from WebCore.gypi. Interesting....
James Robinson
Comment 6 2012-08-17 17:23:32 PDT
Created attachment 159239 [details] Patch
James Robinson
Comment 7 2012-08-17 17:25:02 PDT
Duh, I default-initialized the variable in WebCore.gyp. This inits it as well in WebKit.gyp - I'm not sure if that is the more idomatic thing or if I should set it in WebCore.gypi. Advantage of the latter is I'll only have to flip the default in one place when it comes to that, but the disadvantage is it'll "leak" to a bunch more places. What's the standard practice here?
Dirk Pranke
Comment 8 2012-08-17 17:34:59 PDT
Comment on attachment 159239 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=159239&action=review dunno what the "standard practice" is ... > Source/WebKit/chromium/WebKit.gyp:841 > + 'webkit_compositor_bindings_files', think this needs to be <@(webkit_compositor_bindings_files)
James Robinson
Comment 9 2012-08-17 18:06:51 PDT
Created attachment 159249 [details] Patch
WebKit Review Bot
Comment 10 2012-08-19 21:32:56 PDT
Comment on attachment 159249 [details] Patch Clearing flags on attachment: 159249 Committed r125994: <http://trac.webkit.org/changeset/125994>
WebKit Review Bot
Comment 11 2012-08-19 21:33:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.