Bug 94390 - REGRESSION (r125912): Crashes in worker tests
Summary: REGRESSION (r125912): Crashes in worker tests
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on: 94220
  Show dependency treegraph
Reported: 2012-08-17 16:06 PDT by Alexey Proskuryakov
Modified: 2012-08-17 16:28 PDT (History)
2 users (show)

See Also:

proposed fix (1.97 KB, patch)
2012-08-17 16:08 PDT, Alexey Proskuryakov
beidson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2012-08-17 16:06:17 PDT
Not every global object is a window.
Comment 1 Alexey Proskuryakov 2012-08-17 16:08:54 PDT
Created attachment 159220 [details]
proposed fix
Comment 2 Sam Weinig 2012-08-17 16:15:44 PDT
Comment on attachment 159220 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=159220&action=review

> Source/WebCore/bindings/js/JSDOMBinding.cpp:167
> +    ScriptExecutionContext* scriptExecutionContext = globalObject->scriptExecutionContext();
> +    scriptExecutionContext->reportException(ustringToString(errorMessage), lineNumber, ustringToString(exceptionSourceURL), 0);

I think this can go on one line.
Comment 3 Alexey Proskuryakov 2012-08-17 16:28:12 PDT
Committed <http://trac.webkit.org/changeset/125946>.