Bug 94381 - Add ability to create AtomicString using LChar* buffer and length
: Add ability to create AtomicString using LChar* buffer and length
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Michael Saboff
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-08-17 14:04 PDT by Michael Saboff
Modified: 2012-08-17 17:43 PDT (History)
0 users

See Also:


Attachments
Patch (4.91 KB, patch)
2012-08-17 14:17 PDT, Michael Saboff
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2012-08-17 14:04:24 PDT
Add an AtomicString::add() method that takes an LChar* and length.  This would allow many Atomic string creation sites to use a native 8 bit string instead of up converting to 16 bits before creating.
Comment 1 Michael Saboff 2012-08-17 14:17:28 PDT
Created attachment 159201 [details]
Patch
Comment 2 Geoffrey Garen 2012-08-17 14:19:25 PDT
Comment on attachment 159201 [details]
Patch

r=me

Would be nice to explain what this improves.
Comment 3 Michael Saboff 2012-08-17 14:23:46 PDT
(In reply to comment #2)
> (From update of attachment 159201 [details])
> r=me
> 
> Would be nice to explain what this improves.

This will be used initially in the 8 bit CSS parser path, but other places as well.
Comment 4 Michael Saboff 2012-08-17 17:43:48 PDT
Committed r125958: <http://trac.webkit.org/changeset/125958>