Bug 94369 - [chromium] Add content shell bots to the flakiness dashboard
Summary: [chromium] Add content shell bots to the flakiness dashboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-17 11:24 PDT by jochen
Modified: 2012-08-17 12:57 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.54 KB, patch)
2012-08-17 11:26 PDT, jochen 		no flags Details | Formatted Diff | Diff
Patch for landing (3.36 KB, patch)
2012-08-17 12:10 PDT, jochen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2012-08-17 11:24:52 PDT 
[chromium] Add content shell bots to the flakiness dashboard
Comment 1 jochen 2012-08-17 11:26:16 PDT 
Created attachment 159166 [details]
Patch
Comment 2 jochen 2012-08-17 11:27:35 PDT 
For reference, the builder is here: http://build.chromium.org/p/chromium.webkit/builders/Linux%20%28Content%20Shell%29

I'm going to add windoes and mac builders soon
Comment 3 Ojan Vafai 2012-08-17 11:31:45 PDT 
Comment on attachment 159166 [details]
Patch

Just to be clear, you'll only be adding "Content Shell" builders that run the layout tests, right? Otherwise, we'll start showing bots that don't have content and the dashboard will show big red error messages. Not the end of the world. :)
Comment 4 Ojan Vafai 2012-08-17 11:32:35 PDT 
Comment on attachment 159166 [details]
Patch

If you feel moved, there is a unittest for this in flakiness_dashboard_unittests.js that you could add a couple cases too. Not a big deal since you're not really changing logic.
Comment 5 jochen 2012-08-17 12:10:18 PDT 
Created attachment 159175 [details]
Patch for landing
Comment 6 jochen 2012-08-17 12:11:43 PDT 
(In reply to comment #3)
> (From update of attachment 159166 [details])
> Just to be clear, you'll only be adding "Content Shell" builders that run the layout tests, right? Otherwise, we'll start showing bots that don't have content and the dashboard will show big red error messages. Not the end of the world. :)

Right, they will all run layout tests
Comment 7 WebKit Review Bot 2012-08-17 12:57:35 PDT 
Comment on attachment 159175 [details]
Patch for landing

Clearing flags on attachment: 159175

Committed r125926: <http://trac.webkit.org/changeset/125926>
Comment 8 WebKit Review Bot 2012-08-17 12:57:38 PDT 
All reviewed patches have been landed.  Closing bug.