Bug 94367 - [chromium] context-menu.html fails on Chromium Mac
Summary: [chromium] context-menu.html fails on Chromium Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-17 11:10 PDT by Adrienne Walker
Modified: 2012-08-20 01:14 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.70 KB, patch)
2012-08-20 01:11 PDT, Allan Sandfeld Jensen
kenneth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrienne Walker 2012-08-17 11:10:08 PDT
The context-menu.html test added in http://trac.webkit.org/changeset/125898 does not pass on Chromium Mac.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=touchadjustment%2Fcontext-menu.html

Test touch adjustment for context-menu gestures.

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".


PASS adjusted node was A#a0.
PASS adjusted node was SPAN#span0.
FAIL adjusted node should be null. Was SPAN#span0.
PASS adjusted node was SPAN#span0.
PASS adjusted node was IMG#img0.
PASS adjusted node was A#a0.
FAIL adjusted node should be null. Was SPAN#span0.
FAIL adjusted node should be A#a0. Was SPAN#span0.
PASS adjusted node was IMG#img0.
FAIL adjusted node should be IMG#img0. Was SPAN.
PASS adjusted node was SPAN#span0.
PASS successfullyParsed is true

TEST COMPLETE
Comment 1 Adrienne Walker 2012-08-17 11:12:07 PDT
Committed r125914: <http://trac.webkit.org/changeset/125914>
Comment 2 Allan Sandfeld Jensen 2012-08-17 16:27:45 PDT
The test needs probably needs to set editing behaviour 'win' or 'unix'. With 'mac' editing behaviour the result is different. I didn't expect the test-runners would change fundamental behaviour between platforms though.
Comment 3 Allan Sandfeld Jensen 2012-08-20 01:11:24 PDT
Created attachment 159354 [details]
Patch
Comment 4 Allan Sandfeld Jensen 2012-08-20 01:13:16 PDT
I assume there is a very good reason the test-runner has different default settings between operating system, because if there isn't; the right solution would be to have the test-runner to set a consistent default.
Comment 5 Allan Sandfeld Jensen 2012-08-20 01:14:51 PDT
Committed r126006: <http://trac.webkit.org/changeset/126006>