Bug 94358 - [CSS Shaders] Get rid of internal tex coord attribute
Summary: [CSS Shaders] Get rid of internal tex coord attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Max Vujovic
URL:
Keywords:
Depends on: 93869 98972
Blocks:
  Show dependency tree / graph
 
Reported: 2012-08-17 10:00 PDT by Max Vujovic
Modified: 2012-11-01 16:59 PDT (History)
5 users (show)

See Also:

Attachments
Patch (15.09 KB, patch)
2012-10-30 14:43 PDT, Max Vujovic 		gtk-ews: commit-queue-
Details | Formatted Diff | Diff
Patch (15.09 KB, patch)
2012-10-30 16:57 PDT, Max Vujovic 		no flags Details | Formatted Diff | Diff
Patch (15.36 KB, patch)
2012-10-31 15:04 PDT, Max Vujovic 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Max Vujovic 2012-08-17 10:00:32 PDT 
We should get rid of the internal tex coord attribute "css_a_texCoord" that we needed to introduce in bug 93869.

If the author defines "a_texCoord", we should leverage that. If not, we should add "a_texCoord" to the shader. This requires us to first get the list of attributes from the vertex shader using ANGLE.
Comment 1 Max Vujovic 2012-10-30 14:43:37 PDT 
Created attachment 171524 [details]
Patch
Comment 2 kov's GTK+ EWS bot 2012-10-30 15:35:30 PDT 
Comment on attachment 171524 [details]
Patch

Attachment 171524 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/14664020
Comment 3 Max Vujovic 2012-10-30 16:57:57 PDT 
Created attachment 171552 [details]
Patch

Trying the GTK bot again with the same patch. The failure seems unrelated to this patch's contents:
"""
Failed to create file 'Programs/resources/webkit2gtk-tests-resourcFailed to run "['Tools/Scripts/build-webkit', '--release', '--gtk', '--update-gtk', '--makeargs="-j8"']" exit_code: 2
"""
Comment 4 Alexandru Chiculita 2012-10-31 11:40:51 PDT 
Comment on attachment 171552 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171552&action=review

Looks good!

> Source/WebCore/platform/graphics/filters/CustomFilterValidatedProgram.cpp:212
> +    if (!texCoordAttributeDefined)
> +        m_validatedVertexShader.append("attribute mediump vec2 a_texCoord;");

Add a comment explaining that a_texCoord is read-only and that even if we reuse the same one that the user had access to, it's not going to change.
Comment 5 Max Vujovic 2012-10-31 15:04:15 PDT 
Created attachment 171728 [details]
Patch
Comment 6 Max Vujovic 2012-10-31 15:06:26 PDT 
Thanks for looking at this!

(In reply to comment #4)
> (From update of attachment 171552 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171552&action=review
> 
> Looks good!
> 
> > Source/WebCore/platform/graphics/filters/CustomFilterValidatedProgram.cpp:212
> > +    if (!texCoordAttributeDefined)
> > +        m_validatedVertexShader.append("attribute mediump vec2 a_texCoord;");
> 
> Add a comment explaining that a_texCoord is read-only and that even if we reuse the same one that the user had access to, it's not going to change.

Done.
Comment 7 WebKit Review Bot 2012-11-01 16:59:22 PDT 
Comment on attachment 171728 [details]
Patch

Clearing flags on attachment: 171728

Committed r133241: <http://trac.webkit.org/changeset/133241>
Comment 8 WebKit Review Bot 2012-11-01 16:59:26 PDT 
All reviewed patches have been landed.  Closing bug.