Bug 94358 – [CSS Shaders] Get rid of internal tex coord attribute

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Max Vujovic]

We should get rid of the internal tex coord attribute "css_a_texCoord" that we needed to introduce in bug 93869.

If the author defines "a_texCoord", we should leverage that. If not, we should add "a_texCoord" to the shader. This requires us to first get the list of attributes from the vertex shader using ANGLE.

[Max Vujovic]

Created attachment 171524 [details]
Patch

[kov's GTK+ EWS bot]

Comment on attachment 171524 [details]
Patch

Attachment 171524 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/14664020

[Max Vujovic]

Created attachment 171552 [details]
Patch

Trying the GTK bot again with the same patch. The failure seems unrelated to this patch's contents:
"""
Failed to create file 'Programs/resources/webkit2gtk-tests-resourcFailed to run "['Tools/Scripts/build-webkit', '--release', '--gtk', '--update-gtk', '--makeargs="-j8"']" exit_code: 2
"""

[Alexandru Chiculita]

Comment on attachment 171552 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171552&action=review

Looks good!

> Source/WebCore/platform/graphics/filters/CustomFilterValidatedProgram.cpp:212
> +    if (!texCoordAttributeDefined)
> +        m_validatedVertexShader.append("attribute mediump vec2 a_texCoord;");

Add a comment explaining that a_texCoord is read-only and that even if we reuse the same one that the user had access to, it's not going to change.

[Max Vujovic]

Created attachment 171728 [details]
Patch

[Max Vujovic]

Thanks for looking at this!

(In reply to comment #4)
> (From update of attachment 171552 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=171552&action=review
> 
> Looks good!
> 
> > Source/WebCore/platform/graphics/filters/CustomFilterValidatedProgram.cpp:212
> > +    if (!texCoordAttributeDefined)
> > +        m_validatedVertexShader.append("attribute mediump vec2 a_texCoord;");
> 
> Add a comment explaining that a_texCoord is read-only and that even if we reuse the same one that the user had access to, it's not going to change.

Done.

[WebKit Review Bot]

Comment on attachment 171728 [details]
Patch

Clearing flags on attachment: 171728

Committed r133241: <http://trac.webkit.org/changeset/133241>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.