Bug 94354 - CSS Masking and CSS Filters applied in wrong order
Summary: CSS Masking and CSS Filters applied in wrong order
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Schulze
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-17 09:49 PDT by Dirk Schulze
Modified: 2012-08-20 16:07 PDT (History)
5 users (show)

See Also:

Attachments
Patch (17.50 KB, patch)
2012-08-18 12:36 PDT, Dirk Schulze 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2012-08-17 09:49:29 PDT 
Looking at the RenderLayer code, I found a bug on the applying order of masking and filters. The Filter Effects spec say that the applying order is: filter, clipping, masking, opacity. In WebKit it is currently: clipping, masking, filters, opacity. So filters should be the first thing to do.
Comment 1 Dirk Schulze 2012-08-17 21:39:33 PDT 
Have a patch for that but need to write a test case first.
Comment 2 Dirk Schulze 2012-08-18 12:36:56 PDT 
Created attachment 159267 [details]
Patch
Comment 3 Simon Fraser (smfr) 2012-08-20 15:21:10 PDT 
Do we get it right in composited mode?
Comment 4 Dirk Schulze 2012-08-20 15:22:02 PDT 
I did not upload an explicit test for it, but yes, it does work with compositing mode.
Comment 5 WebKit Review Bot 2012-08-20 16:07:37 PDT 
Comment on attachment 159267 [details]
Patch

Clearing flags on attachment: 159267

Committed r126084: <http://trac.webkit.org/changeset/126084>
Comment 6 WebKit Review Bot 2012-08-20 16:07:41 PDT 
All reviewed patches have been landed.  Closing bug.