Bug 94340 – Remove RefPtr<Node>s from TextFieldInputType

• Status: RESOLVED
• Resolution: WONTFIX
• Component: DOM

[Kentaro Hara]

To avoid reference cycles of RefPtr<Node>s, we want to remove unnecessary RefPtr<Node>s. The rationale is described in bug 94324.

TextFieldInputType::m_container, TextFieldInputType::m_innerBlock, TextFieldInputType::m_innerText, TextFieldInputType::m_placeholder, TextFieldInputType::m_speechButton and TextFieldInputType::m_innerSpinButton do not need to be RefPtr<Node>s, because they are guaranteed to point to the shadow DOM tree of the TextFieldInputType node, which is guaranteed to exist in the subtree of the TextFieldInputType node.

[Kentaro Hara]

Created attachment 159105 [details]
Patch

[Kent Tamura]

I'm very afraid this change causes security regressions. Text field code is really complex.

So, I won't set r+ unless Bug 87815 is fixed and the patch uses ID access instead of raw pointers.

[Kentaro Hara]

Comment on attachment 159105 [details]
Patch

OK. I'll clear r? because I also don't have a strong intention to land this patch.

[Ahmad Saleem]

I can see from Webkit Github source that this patch didn't landed, some examples below:

https://github.com/WebKit/WebKit/blob/af43ca312063d6ce476c3eb23c3755919916001d/Source/WebCore/html/TextFieldInputType.cpp#L78

https://github.com/WebKit/WebKit/blob/af43ca312063d6ce476c3eb23c3755919916001d/Source/WebCore/html/TextFieldInputType.cpp#L337

https://github.com/WebKit/WebKit/blob/af43ca312063d6ce476c3eb23c3755919916001d/Source/WebCore/html/TextFieldInputType.cpp#L356

[e-mail] - Is this needed now or this can be "RESOLVED LATER"? Thanks!

[Ryosuke Niwa]

We're not gonna do this.