Bug 94339 - Remove RefPtr from SearchInputType::m_resultsButton and SearchInputType::m_cancelButton
Summary: Remove RefPtr from SearchInputType::m_resultsButton and SearchInputType::m_ca...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 94324
  Show dependency tree / graph
 
Reported: 2012-08-17 05:28 PDT by Kentaro Hara
Modified: 2012-08-19 18:08 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.43 KB, patch)
2012-08-17 05:30 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-08-17 05:28:30 PDT 
To avoid reference cycles of RefPtr<Node>s, we want to remove unnecessary RefPtr<Node>s. The rationale is described in bug 94324.

SearchInputType::m_resultsButton and SearchInputType::m_cancelButton do not need to be RefPtr<Node>s, because they are guaranteed to point to the shadow DOM tree of the SearchInputType node, which is guaranteed to exist in the subtree of the SearchInputType node.
Comment 1 Kentaro Hara 2012-08-17 05:30:47 PDT 
Created attachment 159101 [details]
Patch
Comment 2 Kent Tamura 2012-08-19 17:52:34 PDT 
Comment on attachment 159101 [details]
Patch

ok
Comment 3 WebKit Review Bot 2012-08-19 18:08:21 PDT 
Comment on attachment 159101 [details]
Patch

Clearing flags on attachment: 159101

Committed r125984: <http://trac.webkit.org/changeset/125984>
Comment 4 WebKit Review Bot 2012-08-19 18:08:25 PDT 
All reviewed patches have been landed.  Closing bug.