Bug 94338 – Remove RefPtr from HTMLTextAreaElement::m_placeholder

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Kentaro Hara]

To avoid reference cycles of RefPtr<Node>s, we want to remove unnecessary RefPtr<Node>s. The rationale is described in bug 94324.

HTMLTextAreaElement::m_placeholder does not need to be a RefPtr<Node>, because it is guaranteed to point to a shadow DOM tree of the HTMLTextAreaElement node, which is guaranteed to exist in the subtree of the HTMLTextAreaElement node.

[Kentaro Hara]

Created attachment 159096 [details]
Patch

[Abhishek Arya]

Please do check trac.webkit.org for history on who added the refptr. if it a security guy, then best to just run the layout test they added under libgmalloc/asan. we don't wanna regress on security :(:(

[Kentaro Hara]

(In reply to comment #2)
> Please do check trac.webkit.org for history on who added the refptr. if it a security guy, then best to just run the layout test they added under libgmalloc/asan. we don't wanna regress on security :(:(

It's added by tkent at r90971. It looks like it's not added for a security issue.

(Although I believe this patch is safe and will make reference-cycle reasoning simple, I'm not strongly intending to land this patch.)

[Kent Tamura]

Comment on attachment 159096 [details]
Patch

Probably ok

[WebKit Review Bot]

Comment on attachment 159096 [details]
Patch

Clearing flags on attachment: 159096

Committed r126567: <http://trac.webkit.org/changeset/126567>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.