Bug 94338 - Remove RefPtr from HTMLTextAreaElement::m_placeholder
Summary: Remove RefPtr from HTMLTextAreaElement::m_placeholder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
URL:
Keywords:
Depends on:
Blocks: 94324
  Show dependency tree / graph
 
Reported: 2012-08-17 05:18 PDT by Kentaro Hara
Modified: 2012-08-24 03:08 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.01 KB, patch)
2012-08-17 05:20 PDT, Kentaro Hara 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-08-17 05:18:10 PDT 
To avoid reference cycles of RefPtr<Node>s, we want to remove unnecessary RefPtr<Node>s. The rationale is described in bug 94324.

HTMLTextAreaElement::m_placeholder does not need to be a RefPtr<Node>, because it is guaranteed to point to a shadow DOM tree of the HTMLTextAreaElement node, which is guaranteed to exist in the subtree of the HTMLTextAreaElement node.
Comment 1 Kentaro Hara 2012-08-17 05:20:20 PDT 
Created attachment 159096 [details]
Patch
Comment 2 Abhishek Arya 2012-08-22 13:58:22 PDT 
Please do check trac.webkit.org for history on who added the refptr. if it a security guy, then best to just run the layout test they added under libgmalloc/asan. we don't wanna regress on security :(:(
Comment 3 Kentaro Hara 2012-08-22 19:30:56 PDT 
(In reply to comment #2)
> Please do check trac.webkit.org for history on who added the refptr. if it a security guy, then best to just run the layout test they added under libgmalloc/asan. we don't wanna regress on security :(:(

It's added by tkent at r90971. It looks like it's not added for a security issue.

(Although I believe this patch is safe and will make reference-cycle reasoning simple, I'm not strongly intending to land this patch.)
Comment 4 Kent Tamura 2012-08-24 02:52:37 PDT 
Comment on attachment 159096 [details]
Patch

Probably ok
Comment 5 WebKit Review Bot 2012-08-24 03:08:27 PDT 
Comment on attachment 159096 [details]
Patch

Clearing flags on attachment: 159096

Committed r126567: <http://trac.webkit.org/changeset/126567>
Comment 6 WebKit Review Bot 2012-08-24 03:08:30 PDT 
All reviewed patches have been landed.  Closing bug.