Bug 94336 - Remove RefPtr from HTMLProgressElement::m_value
Summary: Remove RefPtr from HTMLProgressElement::m_value
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kentaro Hara
Depends on:
Blocks: 94324
  Show dependency treegraph
Reported: 2012-08-17 05:08 PDT by Kentaro Hara
Modified: 2012-08-19 18:31 PDT (History)
3 users (show)

See Also:

Patch (3.06 KB, patch)
2012-08-17 05:10 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2012-08-17 05:08:57 PDT
To avoid reference cycles of RefPtr<Node>s, we want to remove unnecessary RefPtr<Node>s. The rationale is described in bug 94324.

HTMLProgressElement::m_value does not need to be a RefPtr<Node>, because it is guaranteed to point to a shadow DOM tree of the HTMLProgressElement node, which is guaranteed to exist in the subtree of the HTMLProgressElement node.
Comment 1 Kentaro Hara 2012-08-17 05:10:36 PDT
Created attachment 159093 [details]
Comment 2 Kent Tamura 2012-08-19 17:50:30 PDT
Comment on attachment 159093 [details]

Comment 3 WebKit Review Bot 2012-08-19 18:31:39 PDT
Comment on attachment 159093 [details]

Clearing flags on attachment: 159093

Committed r125985: <http://trac.webkit.org/changeset/125985>
Comment 4 WebKit Review Bot 2012-08-19 18:31:42 PDT
All reviewed patches have been landed.  Closing bug.