RESOLVED FIXED 94330
Remove RefPtr from DateInputType::m_pickerElement 
https://bugs.webkit.org/show_bug.cgi?id=94330
Summary Remove RefPtr from DateInputType::m_pickerElement
Kentaro Hara
Reported 2012-08-17 03:53:44 PDT
To avoid reference cycles of RefPtr<Node>s, we want to remove unnecessary RefPtr<Node>s. The rationale is describe in bug 94324. DateInputType::m_pickerElement does not need to be a RefPtr<Node>, because it is guaranteed to point to a shadow DOM tree of the DateInputType node, which is guaranteed to exist in the subtree of the DateInputType node.
Attachments
Patch (3.06 KB, patch)
2012-08-17 03:58 PDT, Kentaro Hara 		peter+ews: commit-queue-
DetailsFormatted DiffDiff
patch for landing (3.09 KB, patch)
2012-08-17 04:30 PDT, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-08-17 03:58:04 PDT
Created attachment 159076 [details] Patch
Kent Tamura
Comment 2 2012-08-17 04:04:02 PDT
Comment on attachment 159076 [details] Patch ok
Peter Beverloo (cr-android ews)
Comment 3 2012-08-17 04:04:16 PDT
Comment on attachment 159076 [details] Patch Attachment 159076 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13522102
Kentaro Hara
Comment 4 2012-08-17 04:30:00 PDT
Created attachment 159085 [details] patch for landing
WebKit Review Bot
Comment 5 2012-08-17 05:25:31 PDT
Comment on attachment 159085 [details] patch for landing Clearing flags on attachment: 159085 Committed r125886: <http://trac.webkit.org/changeset/125886>
Note You need to log in before you can comment on or make changes to this bug.