Bug 94328 – [BlackBerry][EFL] Remove compile warning in WebCore

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Kangil Han]

Fixed compile time warning in WebCore.

[Kangil Han]

Created attachment 159075 [details]
patch

[Rob Buis]

Comment on attachment 159075 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159075&action=review

> Source/WebCore/ChangeLog:13
> +        (WebCore::HarfBuzzShaper::selectionRect): âtoXâ may be used uninitialized in this function [-Wuninitialized], âfromXâ may be used uniniti

Some problems with quotes?

> Source/WebCore/platform/efl/RenderThemeEfl.cpp:455
> +            EINA_LOG_ERR("Could not set file: %s", errmsg);

Is this part of the patch?

> Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:407
> +    float toX = 0;

This part is fine.

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 159075 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159075&action=review

>> Source/WebCore/platform/efl/RenderThemeEfl.cpp:455
>> +            EINA_LOG_ERR("Could not set file: %s", errmsg);
> 
> Is this part of the patch?

In a way yes, as those error values were obtained in the previous lines but not used/reported anywhere.

[Rob Buis]

(In reply to comment #3)
> (From update of attachment 159075 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=159075&action=review
> 
> >> Source/WebCore/platform/efl/RenderThemeEfl.cpp:455
> >> +            EINA_LOG_ERR("Could not set file: %s", errmsg);
> > 
> > Is this part of the patch?
> 
> In a way yes, as those error values were obtained in the previous lines but not used/reported anywhere.

Thanks, I see now that it is a warning fix.

[Rob Buis]

Comment on attachment 159075 [details]
patch

LGTM.

[WebKit Review Bot]

Comment on attachment 159075 [details]
patch

Clearing flags on attachment: 159075

Committed r125948: <http://trac.webkit.org/changeset/125948>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.