Bug 94327 - [EFL] Change font family/script on layout tests causes flakiness
Summary: [EFL] Change font family/script on layout tests causes flakiness
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Thiago Marcos P. Santos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-17 03:43 PDT by Thiago Marcos P. Santos
Modified: 2012-08-17 05:23 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.51 KB, patch)
2012-08-17 04:58 PDT, Thiago Marcos P. Santos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thiago Marcos P. Santos 2012-08-17 03:43:56 PDT
Many tests are flaky on the WK1 bot because changing the font family/script doesn't get properly reset by DRT.

This should pass:
./Tools/Scripts/run-webkit-tests --efl --debug --child-processes=1 ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm

This should also pass:
./Tools/Scripts/run-webkit-tests --efl --debug --child-processes=1 fast/text/international/font-fallback-to-common-script.html

Running both tests sequentially reveals flakiness:
./Tools/Scripts/run-webkit-tests --efl --debug --child-processes=1 fast/text/international/font-fallback-to-common-script.html ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm
Comment 1 Thiago Marcos P. Santos 2012-08-17 04:58:37 PDT
Created attachment 159089 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2012-08-17 05:16:51 PDT
Comment on attachment 159089 [details]
Patch

It is possible to write a test which always fails without this change?
Comment 3 Chris Dumez 2012-08-17 05:19:47 PDT
Comment on attachment 159089 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159089&action=review

> Source/WebKit/efl/ewk/ewk_view.cpp:2505
> +        eina_stringshare_replace(&priv->settings.fontStandard, name);

I would have added a comment in the code to explain why it is needed to call setStandardFontFamily() even if the font family has not changed. This would make sure someone does not break this when refactoring.
Comment 4 WebKit Review Bot 2012-08-17 05:23:36 PDT
Comment on attachment 159089 [details]
Patch

Clearing flags on attachment: 159089

Committed r125885: <http://trac.webkit.org/changeset/125885>
Comment 5 WebKit Review Bot 2012-08-17 05:23:42 PDT
All reviewed patches have been landed.  Closing bug.