Bug 94327 – [EFL] Change font family/script on layout tests causes flakiness

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Thiago Marcos P. Santos]

Many tests are flaky on the WK1 bot because changing the font family/script doesn't get properly reset by DRT.

This should pass:
./Tools/Scripts/run-webkit-tests --efl --debug --child-processes=1 ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm

This should also pass:
./Tools/Scripts/run-webkit-tests --efl --debug --child-processes=1 fast/text/international/font-fallback-to-common-script.html

Running both tests sequentially reveals flakiness:
./Tools/Scripts/run-webkit-tests --efl --debug --child-processes=1 fast/text/international/font-fallback-to-common-script.html ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling.htm

[Thiago Marcos P. Santos]

Created attachment 159089 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 159089 [details]
Patch

It is possible to write a test which always fails without this change?

[Chris Dumez]

Comment on attachment 159089 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159089&action=review

> Source/WebKit/efl/ewk/ewk_view.cpp:2505
> +        eina_stringshare_replace(&priv->settings.fontStandard, name);

I would have added a comment in the code to explain why it is needed to call setStandardFontFamily() even if the font family has not changed. This would make sure someone does not break this when refactoring.

[WebKit Review Bot]

Comment on attachment 159089 [details]
Patch

Clearing flags on attachment: 159089

Committed r125885: <http://trac.webkit.org/changeset/125885>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.