RESOLVED FIXED 94326
Web Inspector: load panels code on demand 
https://bugs.webkit.org/show_bug.cgi?id=94326
Summary Web Inspector: load panels code on demand
Pavel Feldman
Reported 2012-08-17 03:43:37 PDT
Now that we can instantiate panels lazily, we can try loading their code on demand.
Attachments
Patch (44.21 KB, patch)
2012-08-17 04:03 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from gce-cr-linux-06 (393.41 KB, application/zip)
2012-08-17 04:39 PDT, WebKit Review Bot 		no flags
Details
Patch (44.46 KB, patch)
2012-08-17 06:15 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[Patch] with color format moved into Color (50.46 KB, patch)
2012-08-17 06:49 PDT, Pavel Feldman 		vsevik: review+
DetailsFormatted DiffDiff
[Patch] for landing (50.91 KB, patch)
2012-08-17 07:08 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2012-08-17 04:03:03 PDT
Created attachment 159078 [details] Patch
WebKit Review Bot
Comment 2 2012-08-17 04:39:20 PDT
Comment on attachment 159078 [details] Patch Attachment 159078 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13515801 New failing tests: http/tests/inspector/resource-tree/resource-tree-non-unique-url.html
WebKit Review Bot
Comment 3 2012-08-17 04:39:24 PDT
Created attachment 159087 [details] Archive of layout-test-results from gce-cr-linux-06 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: gce-cr-linux-06 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Pavel Feldman
Comment 4 2012-08-17 06:15:18 PDT
Created attachment 159107 [details] Patch
Pavel Feldman
Comment 5 2012-08-17 06:49:08 PDT
Created attachment 159110 [details] [Patch] with color format moved into Color
Vsevolod Vlasov
Comment 6 2012-08-17 06:50:15 PDT
Comment on attachment 159110 [details] [Patch] with color format moved into Color View in context: https://bugs.webkit.org/attachment.cgi?id=159110&action=review > Source/WebCore/ChangeLog:7 > + Loading code on demanu (upon the panel access). typo
Pavel Feldman
Comment 7 2012-08-17 07:08:11 PDT
Created attachment 159119 [details] [Patch] for landing
Pavel Feldman
Comment 8 2012-08-17 07:28:55 PDT
Committed r125897: <http://trac.webkit.org/changeset/125897>
Dirk Pranke
Comment 9 2012-08-17 19:00:59 PDT
Reverted r125897 for reason: broke Committed r125960: <http://trac.webkit.org/changeset/125960>
Dirk Pranke
Comment 10 2012-08-17 19:04:16 PDT
sigh, webkit-patch truncated my comment ... all sorts of inspector tests are failing/timing out on the apple mac bots. See, e.g.: http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r125926%20(2511)/results.html (and I saw this locally as well). Sorry for the rollout :(.
Pavel Feldman
Comment 11 2012-08-18 00:21:02 PDT
Sorry about that. Fixed the Mac inspector concatenator. Committed r125965.
Note You need to log in before you can comment on or make changes to this bug.