Bug 94326 - Web Inspector: load panels code on demand
Summary: Web Inspector: load panels code on demand
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-17 03:43 PDT by Pavel Feldman
Modified: 2012-08-18 00:21 PDT (History)
15 users (show)

See Also:


Attachments
Patch (44.21 KB, patch)
2012-08-17 04:03 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from gce-cr-linux-06 (393.41 KB, application/zip)
2012-08-17 04:39 PDT, WebKit Review Bot
no flags Details
Patch (44.46 KB, patch)
2012-08-17 06:15 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff
[Patch] with color format moved into Color (50.46 KB, patch)
2012-08-17 06:49 PDT, Pavel Feldman
vsevik: review+
Details | Formatted Diff | Diff
[Patch] for landing (50.91 KB, patch)
2012-08-17 07:08 PDT, Pavel Feldman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2012-08-17 03:43:37 PDT
Now that we can instantiate panels lazily, we can try loading their code on demand.
Comment 1 Pavel Feldman 2012-08-17 04:03:03 PDT
Created attachment 159078 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-17 04:39:20 PDT
Comment on attachment 159078 [details]
Patch

Attachment 159078 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13515801

New failing tests:
http/tests/inspector/resource-tree/resource-tree-non-unique-url.html
Comment 3 WebKit Review Bot 2012-08-17 04:39:24 PDT
Created attachment 159087 [details]
Archive of layout-test-results from gce-cr-linux-06

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: gce-cr-linux-06  Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'>  Platform: Linux-2.6.39-gcg-201203291735-x86_64-with-Ubuntu-10.04-lucid
Comment 4 Pavel Feldman 2012-08-17 06:15:18 PDT
Created attachment 159107 [details]
Patch
Comment 5 Pavel Feldman 2012-08-17 06:49:08 PDT
Created attachment 159110 [details]
[Patch] with color format moved into Color
Comment 6 Vsevolod Vlasov 2012-08-17 06:50:15 PDT
Comment on attachment 159110 [details]
[Patch] with color format moved into Color

View in context: https://bugs.webkit.org/attachment.cgi?id=159110&action=review

> Source/WebCore/ChangeLog:7
> +        Loading code on demanu (upon the panel access).

typo
Comment 7 Pavel Feldman 2012-08-17 07:08:11 PDT
Created attachment 159119 [details]
[Patch] for landing
Comment 8 Pavel Feldman 2012-08-17 07:28:55 PDT
Committed r125897: <http://trac.webkit.org/changeset/125897>
Comment 9 Dirk Pranke 2012-08-17 19:00:59 PDT
Reverted r125897 for reason:

broke

Committed r125960: <http://trac.webkit.org/changeset/125960>
Comment 10 Dirk Pranke 2012-08-17 19:04:16 PDT
sigh, webkit-patch truncated my comment ...

all sorts of inspector tests are failing/timing out on the apple mac bots. See, e.g.:

http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r125926%20(2511)/results.html

(and I saw this locally as well).

Sorry for the rollout :(.
Comment 11 Pavel Feldman 2012-08-18 00:21:02 PDT
Sorry about that. Fixed the Mac inspector concatenator.

Committed r125965.