Bug 94322 - Web Inspector: decouple extension server from the Elements panel
Summary: Web Inspector: decouple extension server from the Elements panel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-17 03:10 PDT by Andrey Kosyakov
Modified: 2012-08-17 05:06 PDT (History)
11 users (show)

See Also:


Attachments
Patch (4.54 KB, patch)
2012-08-17 03:13 PDT, Andrey Kosyakov
no flags Details | Formatted Diff | Diff
Patch (3.22 KB, patch)
2012-08-17 04:01 PDT, Andrey Kosyakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-08-17 03:10:20 PDT
Currently, extension server subscribes directly to events dispatched on a member of an Elements panel, which would cause elements panel to be constructed upon any extension adding subscription. Let's move an event sink used to dispatch the event out of the Elements panel.
Comment 1 Andrey Kosyakov 2012-08-17 03:13:17 PDT
Created attachment 159069 [details]
Patch
Comment 2 Pavel Feldman 2012-08-17 03:18:31 PDT
Comment on attachment 159069 [details]
Patch

What is the difference between the WebInspector.notificationService and WebInspector.notifications ?
Comment 3 Andrey Kosyakov 2012-08-17 04:01:20 PDT
Created attachment 159077 [details]
Patch
Comment 4 WebKit Review Bot 2012-08-17 05:06:44 PDT
Comment on attachment 159077 [details]
Patch

Clearing flags on attachment: 159077

Committed r125881: <http://trac.webkit.org/changeset/125881>
Comment 5 WebKit Review Bot 2012-08-17 05:06:49 PDT
All reviewed patches have been landed.  Closing bug.