Bug 94321 – [BlackBerry] Select popup shows blank content when its option tags contain '\' characters

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Sean Wang]

When trigger the selection popup, it shows a blank popup window.

Test case:
<select>
  <option value="1">\</option>
</select>

HOW TO REPRODUCE:
Load the test case and click the select to trigger the popup, see what will happen.

EXPECTED:
A item with the description "\" should be displayed.

ACTUAL:
A blank popup is displayed and there is no cancel button.

[Sean Wang]

Created attachment 159065 [details]
patch

The character in the select options' description should be escaped to avoid it is interpreted as an escape character.

[WebKit Review Bot]

Comment on attachment 159065 [details]
patch

Clearing flags on attachment: 159065

Committed r126128: <http://trac.webkit.org/changeset/126128>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Kent Tamura]

Comment on attachment 159065 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159065&action=review

> Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp:86
> -        source.append("'" + String(labels[i].impl()).replace("'", "\\'") + "'");
> +        source.append("'" + String(labels[i].impl()).replace('\\', "\\\\").replace('\'', "\\'") + "'");

You had better use PagePopupClient::addJavaScriptString().

[Sean Wang]

Comment on attachment 159065 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159065&action=review

>> Source/WebKit/blackberry/WebCoreSupport/SelectPopupClient.cpp:86
>> +        source.append("'" + String(labels[i].impl()).replace('\\', "\\\\").replace('\'', "\\'") + "'");
> 
> You had better use PagePopupClient::addJavaScriptString().

This function has not been merged to our development trunk.