WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 93971
94318
Refactor away IsolatedWorld
https://bugs.webkit.org/show_bug.cgi?id=94318
Summary
Refactor away IsolatedWorld
Dan Carney
Reported
2012-08-17 02:15:35 PDT
Refactor away IsolatedWorld
Attachments
Patch
(15.91 KB, patch)
2012-08-17 02:19 PDT
,
Dan Carney
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dan Carney
Comment 1
2012-08-17 02:19:09 PDT
Created
attachment 159053
[details]
Patch
Kentaro Hara
Comment 2
2012-08-17 02:24:36 PDT
Was the patch in
bug 93971
reverted? The patch in this bug looks almost the same as the patch in
bug 93971
.
Dan Carney
Comment 3
2012-08-17 02:29:32 PDT
(In reply to
comment #2
)
> Was the patch in
bug 93971
reverted? The patch in this bug looks almost the same as the patch in
bug 93971
.
Yes. It was reverted, I believe, due to a bad assertion in V8PerIsolateData that was causing a windows debug bot to fail. I've fixed that assertion.
Kentaro Hara
Comment 4
2012-08-17 02:33:09 PDT
(In reply to
comment #3
)
> (In reply to
comment #2
) > > Was the patch in
bug 93971
reverted? The patch in this bug looks almost the same as the patch in
bug 93971
. > > Yes. It was reverted, I believe, due to a bad assertion in V8PerIsolateData that was causing a windows debug bot to fail. I've fixed that assertion.
OK, then would you please upload the patch to
bug 93971
, instead of creating a new bug? We don't want to split one discussion into multiple bugs, which makes it difficult to track what discussion had been done for the patch. I'm sorry for the non-technical inconvenience though. *** This bug has been marked as a duplicate of
bug 93971
***
Dan Carney
Comment 5
2012-08-17 02:45:30 PDT
> OK, then would you please upload the patch to
bug 93971
, instead of creating a new bug? We don't want to split one discussion into multiple bugs, which makes it difficult to track what discussion had been done for the patch. I'm sorry for the non-technical inconvenience though.
done!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug