Bug 94314 - [GTK] Missing transfer annotations for webkit_web_context_get_default
Summary: [GTK] Missing transfer annotations for webkit_web_context_get_default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-17 01:56 PDT by Jesse van den Kieboom
Modified: 2012-10-30 13:18 PDT (History)
2 users (show)

See Also:


Attachments
Fixed transfer annotation (913 bytes, patch)
2012-08-17 06:39 PDT, Jesse van den Kieboom
no flags Details | Formatted Diff | Diff
Fixed transfer annotation for default web context (1.63 KB, patch)
2012-10-30 11:31 PDT, Jesse van den Kieboom
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse van den Kieboom 2012-08-17 01:56:56 PDT
There is a missing semicolon for the transfer annotation in webkit_web_context_get_default. Patch attached.
Comment 1 Carlos Garcia Campos 2012-08-17 06:06:50 PDT
It seems you forgot to attach the patch :-)
Comment 2 Jesse van den Kieboom 2012-08-17 06:39:45 PDT
Created attachment 159109 [details]
Fixed transfer annotation

Hmm, seems it didn't work while filing the new bug report at the same time (maybe I forgot to add a description). Anyway, here it is. It's trivial. I'll also make a new patch including the ChangeLog.
Comment 3 Jesse van den Kieboom 2012-10-30 02:29:41 PDT
Ping!
Comment 4 Carlos Garcia Campos 2012-10-30 02:38:04 PDT
(In reply to comment #3)
> Ping!

"I'll also make a new patch including the ChangeLog."

:-)
Comment 5 Jesse van den Kieboom 2012-10-30 11:31:46 PDT
Created attachment 171489 [details]
Fixed transfer annotation for default web context

Ah right! Added a changelog entry.
Comment 6 Martin Robinson 2012-10-30 11:34:31 PDT
Comment on attachment 171489 [details]
Fixed transfer annotation for default web context

Thanks!
Comment 7 WebKit Review Bot 2012-10-30 13:18:27 PDT
Comment on attachment 171489 [details]
Fixed transfer annotation for default web context

Clearing flags on attachment: 171489

Committed r132940: <http://trac.webkit.org/changeset/132940>
Comment 8 WebKit Review Bot 2012-10-30 13:18:30 PDT
All reviewed patches have been landed.  Closing bug.