Bug 94309 - DFG is still too pessimistic about what constitutes a side-effect on array accesses
Summary: DFG is still too pessimistic about what constitutes a side-effect on array ac...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 91933
  Show dependency tree / graph
 
Reported: 2012-08-17 01:07 PDT by Filip Pizlo
Modified: 2012-08-17 17:57 PDT (History)
6 users (show)

See Also:

Attachments
the patch (3.74 KB, patch)
2012-08-17 01:27 PDT, Filip Pizlo 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-08-17 01:07:03 PDT 
The change to introduce PutByValSafe, and the change to eliminate the use of array predictions in selecting what kind of access to use, was not completely propagated to the structure check hoister or the CFA.
Comment 1 Filip Pizlo 2012-08-17 01:27:27 PDT 
Created attachment 159044 [details]
the patch
Comment 2 Geoffrey Garen 2012-08-17 14:16:08 PDT 
Comment on attachment 159044 [details]
the patch

r=me
Comment 3 Filip Pizlo 2012-08-17 17:57:30 PDT 
Landed in http://trac.webkit.org/changeset/125959