Bug 94308 - [EFL][WK2] Getting unnecessary EINA_SAFETY_ON_NULL_RETURN_VAL warnings while page navigation
Summary: [EFL][WK2] Getting unnecessary EINA_SAFETY_ON_NULL_RETURN_VAL warnings while...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-17 01:01 PDT by Mikhail Pozdnyakov
Modified: 2012-08-17 02:25 PDT (History)
4 users (show)

See Also:

Attachments
patch (1.88 KB, patch)
2012-08-17 01:05 PDT, Mikhail Pozdnyakov 		kenneth: review+
kenneth: commit-queue-
Details | Formatted Diff | Diff
to be landed (1.96 KB, patch)
2012-08-17 01:31 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-08-17 01:01:53 PDT 
Getting following message while back-forward page navigation:

ERR<17498>: /media/ssd/WebKit/Source/WebKit2/UIProcess/API/efl/ewk_back_forward_list.cpp:76 addItemToWrapperCache() safety check failed: wkItem == NULL

The reason is that loadClient.didChangeBackForwardList callback is invoked with zero arguments which is valid case
while page back-forward navigation and means basically that the back-froward list has changed but items were not added or deleted.
Comment 1 Mikhail Pozdnyakov 2012-08-17 01:05:15 PDT 
Created attachment 159035 [details]
patch
Comment 2 Chris Dumez 2012-08-17 01:14:07 PDT 
Comment on attachment 159035 [details]
patch

LGTM.
Comment 3 Kenneth Rohde Christiansen 2012-08-17 01:23:56 PDT 
Comment on attachment 159035 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=159035&action=review

> Source/WebKit2/UIProcess/API/efl/ewk_back_forward_list.cpp:132
> -    addItemToWrapperCache(list, wkAddedItem); // Puts new item to the cache.
> +    if (wkAddedItem)
> +        addItemToWrapperCache(list, wkAddedItem); // Puts new item to the cache.

A comment in the code makes sense
Comment 4 Mikhail Pozdnyakov 2012-08-17 01:31:47 PDT 
Created attachment 159045 [details]
to be landed
Comment 5 WebKit Review Bot 2012-08-17 02:25:28 PDT 
Comment on attachment 159045 [details]
to be landed

Clearing flags on attachment: 159045

Committed r125872: <http://trac.webkit.org/changeset/125872>
Comment 6 WebKit Review Bot 2012-08-17 02:25:33 PDT 
All reviewed patches have been landed.  Closing bug.