Bug 94306 - [GTK] Rename WebKitWebView print-requested signal to print
Summary: [GTK] Rename WebKitWebView print-requested signal to print
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2012-08-17 00:48 PDT by Carlos Garcia Campos
Modified: 2012-08-17 06:11 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.92 KB, patch)
2012-08-17 00:52 PDT, Carlos Garcia Campos 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-08-17 00:48:03 PDT 
WebKitWebView::print-requested is inconsistent with the resto of the API. It's a true_handled signal that allows users to implement their own print dialog, or block printing, or rely on defaults. The signal should be WebKitWebView::print like other signals (create, close, decide_policy, etc.)
Comment 1 Carlos Garcia Campos 2012-08-17 00:52:46 PDT 
Created attachment 159031 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-17 00:55:51 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2012-08-17 06:11:40 PDT 
Committed r125890: <http://trac.webkit.org/changeset/125890>