Bug 94294 - Separate MarkStackThreadSharedData from MarkStack
Summary: Separate MarkStackThreadSharedData from MarkStack
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-16 22:22 PDT by Mark Hahnenberg
Modified: 2012-08-22 14:48 PDT (History)
8 users (show)

See Also:

Attachments
Patch (20.67 KB, patch)
2012-08-16 22:24 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (33.34 KB, patch)
2012-08-22 11:34 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2012-08-16 22:22:29 PDT 
MarkStackThreadSharedData is soon going to have data to allow for a parallel copying mode too, so to separate our concerns we should split it out into its own set of files and rename it to GCThreadSharedData. This is purely a cosmetic refactoring.
Comment 1 Mark Hahnenberg 2012-08-16 22:24:31 PDT 
Created attachment 158996 [details]
Patch
Comment 2 Gustavo Noronha (kov) 2012-08-16 22:34:10 PDT 
Comment on attachment 158996 [details]
Patch

Attachment 158996 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/13513904
Comment 3 Gyuyoung Kim 2012-08-16 22:39:07 PDT 
Comment on attachment 158996 [details]
Patch

Attachment 158996 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/13510884
Comment 4 Early Warning System Bot 2012-08-16 22:47:14 PDT 
Comment on attachment 158996 [details]
Patch

Attachment 158996 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/13513908
Comment 5 Early Warning System Bot 2012-08-16 22:49:11 PDT 
Comment on attachment 158996 [details]
Patch

Attachment 158996 [details] did not pass qt-wk2-ews (qt):
Output: http://queues.webkit.org/results/13520287
Comment 6 Build Bot 2012-08-16 23:03:37 PDT 
Comment on attachment 158996 [details]
Patch

Attachment 158996 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/13514665
Comment 7 Gyuyoung Kim 2012-08-16 23:05:03 PDT 
Comment on attachment 158996 [details]
Patch

It looks GCThreadSharedData.cpp file wasn't added to this patch.
Comment 8 Build Bot 2012-08-17 03:57:02 PDT 
Comment on attachment 158996 [details]
Patch

Attachment 158996 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/13516748
Comment 9 Mark Hahnenberg 2012-08-22 11:34:54 PDT 
Created attachment 159981 [details]
Patch
Comment 10 Filip Pizlo 2012-08-22 14:25:19 PDT 
rs=me.
Comment 11 WebKit Review Bot 2012-08-22 14:48:54 PDT 
Comment on attachment 159981 [details]
Patch

Clearing flags on attachment: 159981

Committed r126354: <http://trac.webkit.org/changeset/126354>
Comment 12 WebKit Review Bot 2012-08-22 14:48:59 PDT 
All reviewed patches have been landed.  Closing bug.