Bug 94287 - [Forms] Cleanup CSS selectors for multiple fields time input UI
Summary: [Forms] Cleanup CSS selectors for multiple fields time input UI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks: 94196
  Show dependency tree / graph
 
Reported: 2012-08-16 19:04 PDT by yosin
Modified: 2012-08-16 21:10 PDT (History)
5 users (show)

See Also:

Attachments
Patch 1 (128.13 KB, patch)
2012-08-16 20:57 PDT, yosin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-08-16 19:04:39 PDT 
- Add margin left to spin button
- Remove "width" selector
- Use "em" instead of "px"
Comment 1 yosin 2012-08-16 20:57:39 PDT 
Created attachment 158987 [details]
Patch 1
Comment 2 yosin 2012-08-16 20:59:09 PDT 
Comment on attachment 158987 [details]
Patch 1

Could you review this patch?
Thanks in advance.

Note: Tests are moved from bug 94196, which will contain only functional tests.
Comment 3 Kent Tamura 2012-08-16 21:07:52 PDT 
Comment on attachment 158987 [details]
Patch 1

Looks good.
Comment 4 yosin 2012-08-16 21:10:47 PDT 
Comment on attachment 158987 [details]
Patch 1

Clearing flags on attachment: 158987

Committed r125849: <http://trac.webkit.org/changeset/125849>
Comment 5 yosin 2012-08-16 21:10:53 PDT 
All reviewed patches have been landed.  Closing bug.