Bug 94282 - Delete dead code in deprecated flexbox for RTL line-clamp
Summary: Delete dead code in deprecated flexbox for RTL line-clamp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ojan Vafai
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-16 18:18 PDT by Ojan Vafai
Modified: 2012-08-17 13:42 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.37 KB, patch)
2012-08-16 18:18 PDT, Ojan Vafai 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ojan Vafai 2012-08-16 18:18:06 PDT 
Delete dead code in deprecated flexbox for RTL line-clamp
Comment 1 Ojan Vafai 2012-08-16 18:18:55 PDT 
Created attachment 158964 [details]
Patch
Comment 2 Tony Chang 2012-08-16 18:27:24 PDT 
Comment on attachment 158964 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158964&action=review

> Source/WebCore/ChangeLog:9
> +        -webkit-line-clamp and direction:rtl is not supported. Delete some
> +        obviously dead code that half-tries to support it.

Does this change cause a visible difference?  It's probably OK if it does, but we should still have a test case to show it.
Comment 3 Ojan Vafai 2012-08-16 18:39:08 PDT 
Comment on attachment 158964 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158964&action=review

>> Source/WebCore/ChangeLog:9
>> +        obviously dead code that half-tries to support it.
> 
> Does this change cause a visible difference?  It's probably OK if it does, but we should still have a test case to show it.

No. It's actually just deleting dead code. If you look like 3 lines above you can see that leftToRight is always true.
Comment 4 WebKit Review Bot 2012-08-17 13:42:41 PDT 
Comment on attachment 158964 [details]
Patch

Clearing flags on attachment: 158964

Committed r125929: <http://trac.webkit.org/changeset/125929>
Comment 5 WebKit Review Bot 2012-08-17 13:42:48 PDT 
All reviewed patches have been landed.  Closing bug.