Bug 94281 - [Chromium-win] Use native digits in parsing/formatting dates in the textfield part of input[type=date]
Summary: [Chromium-win] Use native digits in parsing/formatting dates in the textfield...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on: 94210
Blocks:
  Show dependency tree / graph
 
Reported: 2012-08-16 18:17 PDT by Kent Tamura
Modified: 2012-08-20 20:05 PDT (History)
2 users (show)

See Also:

Attachments
Patch 1 (8.26 KB, patch)
2012-08-16 18:27 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2012-08-16 18:17:35 PDT 
[Chromium-win] Use native digits in parsing/formatting dates in the textfield part of input[type=date]
Comment 1 Kent Tamura 2012-08-16 18:27:22 PDT 
Created attachment 158967 [details]
Patch 1
Comment 2 Hajime Morrita 2012-08-20 18:30:34 PDT 
Comment on attachment 158967 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=158967&action=review

> Source/WebCore/platform/text/LocaleWin.h:83
> +    void appendFourDigitsNumber(int, StringBuilder&);

It looks now we are able to have unittests for these?
Comment 3 Kent Tamura 2012-08-20 18:40:07 PDT 
Comment on attachment 158967 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=158967&action=review

>> Source/WebCore/platform/text/LocaleWin.h:83
>> +    void appendFourDigitsNumber(int, StringBuilder&);
> 
> It looks now we are able to have unittests for these?

Yes, but I think existing test cases in LocaleWinTest.cpp cover them well.
I hesitate to make unit tests for such small functions because we have a plan to change the code drastically.
Comment 4 Hajime Morrita 2012-08-20 19:12:56 PDT 
Comment on attachment 158967 [details]
Patch 1

ok.
Comment 5 Kent Tamura 2012-08-20 19:17:09 PDT 
Comment on attachment 158967 [details]
Patch 1

thanks
Comment 6 WebKit Review Bot 2012-08-20 20:05:02 PDT 
Comment on attachment 158967 [details]
Patch 1

Clearing flags on attachment: 158967

Committed r126126: <http://trac.webkit.org/changeset/126126>
Comment 7 WebKit Review Bot 2012-08-20 20:05:06 PDT 
All reviewed patches have been landed.  Closing bug.