Bug 94281 – [Chromium-win] Use native digits in parsing/formatting dates in the textfield part of input[type=date]

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Kent Tamura]

[Chromium-win] Use native digits in parsing/formatting dates in the textfield part of input[type=date]

[Kent Tamura]

Created attachment 158967 [details]
Patch 1

[Hajime Morrita]

Comment on attachment 158967 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=158967&action=review

> Source/WebCore/platform/text/LocaleWin.h:83
> +    void appendFourDigitsNumber(int, StringBuilder&);

It looks now we are able to have unittests for these?

[Kent Tamura]

Comment on attachment 158967 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=158967&action=review

>> Source/WebCore/platform/text/LocaleWin.h:83
>> +    void appendFourDigitsNumber(int, StringBuilder&);
> 
> It looks now we are able to have unittests for these?

Yes, but I think existing test cases in LocaleWinTest.cpp cover them well.
I hesitate to make unit tests for such small functions because we have a plan to change the code drastically.

[Hajime Morrita]

Comment on attachment 158967 [details]
Patch 1

ok.

[Kent Tamura]

Comment on attachment 158967 [details]
Patch 1

thanks

[WebKit Review Bot]

Comment on attachment 158967 [details]
Patch 1

Clearing flags on attachment: 158967

Committed r126126: <http://trac.webkit.org/changeset/126126>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.