Bug 94269 - IndexedDB: Test if getting a TRANSACTION_INACTIVE_ERR is possible when setting version
Summary: IndexedDB: Test if getting a TRANSACTION_INACTIVE_ERR is possible when settin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Grogan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-16 16:49 PDT by David Grogan
Modified: 2012-08-17 16:11 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.08 KB, patch)
2012-08-16 16:54 PDT, David Grogan 		no flags Details | Formatted Diff | Diff
Patch for landing (3.11 KB, patch)
2012-08-17 14:37 PDT, David Grogan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Grogan 2012-08-16 16:49:48 PDT 
IndexedDB: Test if getting a TRANSACTION_INACTIVE_ERR is possible when setting version
Comment 1 David Grogan 2012-08-16 16:54:09 PDT 
Created attachment 158945 [details]
Patch
Comment 2 David Grogan 2012-08-16 17:12:33 PDT 
Alec, could you look at this?

It looks like Josh had similar suspicions, as his patch in https://bugs.webkit.org/attachment.cgi?id=158936&action=review#line228 changes this to ASSERT(ok).
Comment 3 Alec Flett 2012-08-17 13:59:45 PDT 
Comment on attachment 158945 [details]
Patch

lgtm
Comment 4 David Grogan 2012-08-17 14:05:03 PDT 
Ojan, could you review this 5-liner?
Comment 5 Ojan Vafai 2012-08-17 14:14:25 PDT 
Comment on attachment 158945 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158945&action=review

> Source/WebCore/ChangeLog:13
> +        is not hit after a while, change it to ASSERT(ok).

By ASSERT(ok), do you mean ASSERT(transaction.scheduleTask(...))?
Comment 6 David Grogan 2012-08-17 14:37:12 PDT 
Created attachment 159207 [details]
Patch for landing
Comment 7 David Grogan 2012-08-17 14:37:28 PDT 
Comment on attachment 158945 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158945&action=review

Thanks for the review.

>> Source/WebCore/ChangeLog:13
>> +        is not hit after a while, change it to ASSERT(ok).
> 
> By ASSERT(ok), do you mean ASSERT(transaction.scheduleTask(...))?

Yes, changed.
Comment 8 WebKit Review Bot 2012-08-17 16:11:38 PDT 
Comment on attachment 159207 [details]
Patch for landing

Clearing flags on attachment: 159207

Committed r125943: <http://trac.webkit.org/changeset/125943>
Comment 9 WebKit Review Bot 2012-08-17 16:11:41 PDT 
All reviewed patches have been landed.  Closing bug.