Bug 94267 - [jhbuild] EFL now runs jhbuild update for every build
Summary: [jhbuild] EFL now runs jhbuild update for every build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gustavo Noronha (kov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-16 16:42 PDT by Gustavo Noronha (kov)
Modified: 2012-08-20 22:01 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.33 KB, patch)
2012-08-16 16:46 PDT, Gustavo Noronha (kov)
no flags Details | Formatted Diff | Diff
Patch (1.10 KB, patch)
2012-08-20 16:06 PDT, Gustavo Noronha (kov)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2012-08-16 16:42:22 PDT
[jhbuild] EFL now runs jhbuild update for every build
Comment 1 Gustavo Noronha (kov) 2012-08-16 16:46:18 PDT
Created attachment 158941 [details]
Patch
Comment 2 Dirk Pranke 2012-08-16 22:27:53 PDT
Comment on attachment 158941 [details]
Patch

looks plausible.
Comment 3 Gyuyoung Kim 2012-08-16 22:48:50 PDT
Comment on attachment 158941 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158941&action=review

Gustavo, thank you for your patch for EFL port. It looks this patch lets the WebKit EFL build update dependency packages when there is --update-efl option, right?

> Tools/Scripts/webkitdirs.pm:2166
> +

Can we add two empty lines ?
Comment 4 WebKit Review Bot 2012-08-16 23:32:55 PDT
Comment on attachment 158941 [details]
Patch

Clearing flags on attachment: 158941

Committed r125862: <http://trac.webkit.org/changeset/125862>
Comment 5 WebKit Review Bot 2012-08-16 23:32:59 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Patrick R. Gansterer 2012-08-20 02:27:45 PDT
(In reply to comment #4)
> (From update of attachment 158941 [details])
> Clearing flags on attachment: 158941
> 
> Committed r125862: <http://trac.webkit.org/changeset/125862>

Broke WinCE build:
Use of uninitialized value $args[97] in join or string at C:/WebKitBuildSlave/wince-release/build/Tools/Scripts/webkitdirs.pm line 2123.
'env' is not recognized as an internal or external command,
operable program or batch file.
Comment 7 Gustavo Noronha (kov) 2012-08-20 16:06:00 PDT
Created attachment 159552 [details]
Patch
Comment 8 Gustavo Noronha (kov) 2012-08-20 16:15:13 PDT
Comment on attachment 159552 [details]
Patch

I have to leave right now, but if this patch passes the EWS bots feel free to cq+ it. I have tested it locally and it seems to work both with and without the jhbuild infrastructure being used, and it should work for wince as well!
Comment 9 WebKit Review Bot 2012-08-20 22:01:22 PDT
Comment on attachment 159552 [details]
Patch

Clearing flags on attachment: 159552

Committed r126133: <http://trac.webkit.org/changeset/126133>
Comment 10 WebKit Review Bot 2012-08-20 22:01:26 PDT
All reviewed patches have been landed.  Closing bug.