RESOLVED FIXED 94267
[jhbuild] EFL now runs jhbuild update for every build 
https://bugs.webkit.org/show_bug.cgi?id=94267
Summary [jhbuild] EFL now runs jhbuild update for every build
Gustavo Noronha (kov)
Reported 2012-08-16 16:42:22 PDT
[jhbuild] EFL now runs jhbuild update for every build
Attachments
Patch (5.33 KB, patch)
2012-08-16 16:46 PDT, Gustavo Noronha (kov) 		no flags
DetailsFormatted DiffDiff
Patch (1.10 KB, patch)
2012-08-20 16:06 PDT, Gustavo Noronha (kov) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2012-08-16 16:46:18 PDT
Created attachment 158941 [details] Patch
Dirk Pranke
Comment 2 2012-08-16 22:27:53 PDT
Comment on attachment 158941 [details] Patch looks plausible.
Gyuyoung Kim
Comment 3 2012-08-16 22:48:50 PDT
Comment on attachment 158941 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=158941&action=review Gustavo, thank you for your patch for EFL port. It looks this patch lets the WebKit EFL build update dependency packages when there is --update-efl option, right? > Tools/Scripts/webkitdirs.pm:2166 > + Can we add two empty lines ?
WebKit Review Bot
Comment 4 2012-08-16 23:32:55 PDT
Comment on attachment 158941 [details] Patch Clearing flags on attachment: 158941 Committed r125862: <http://trac.webkit.org/changeset/125862>
WebKit Review Bot
Comment 5 2012-08-16 23:32:59 PDT
All reviewed patches have been landed. Closing bug.
Patrick R. Gansterer
Comment 6 2012-08-20 02:27:45 PDT
(In reply to comment #4) > (From update of attachment 158941 [details]) > Clearing flags on attachment: 158941 > > Committed r125862: <http://trac.webkit.org/changeset/125862> Broke WinCE build: Use of uninitialized value $args[97] in join or string at C:/WebKitBuildSlave/wince-release/build/Tools/Scripts/webkitdirs.pm line 2123. 'env' is not recognized as an internal or external command, operable program or batch file.
Gustavo Noronha (kov)
Comment 7 2012-08-20 16:06:00 PDT
Created attachment 159552 [details] Patch
Gustavo Noronha (kov)
Comment 8 2012-08-20 16:15:13 PDT
Comment on attachment 159552 [details] Patch I have to leave right now, but if this patch passes the EWS bots feel free to cq+ it. I have tested it locally and it seems to work both with and without the jhbuild infrastructure being used, and it should work for wince as well!
WebKit Review Bot
Comment 9 2012-08-20 22:01:22 PDT
Comment on attachment 159552 [details] Patch Clearing flags on attachment: 159552 Committed r126133: <http://trac.webkit.org/changeset/126133>
WebKit Review Bot
Comment 10 2012-08-20 22:01:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.