RESOLVED FIXED 94260
Delete ThemeChromiumMac, use ThemeMac in chromium/mac instead 
https://bugs.webkit.org/show_bug.cgi?id=94260
Summary Delete ThemeChromiumMac, use ThemeMac in chromium/mac instead
Nico Weber
Reported 2012-08-16 15:42:12 PDT
Delete ThemeChromiumMac, use ThemeMac in chromium/mac instead
Attachments
Patch (40.07 KB, patch)
2012-08-16 15:45 PDT, Nico Weber 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nico Weber
Comment 1 2012-08-16 15:45:37 PDT
Created attachment 158929 [details] Patch
Avi Drissman
Comment 2 2012-08-16 16:12:31 PDT
The original fork notes the changes: - The import of FlippedView() and its use as the parent view for cell rendering. - In updateStates() the code to update the cells' inactive state. - In paintButton() the code to save/restore the window's default button cell. - The Snow Leopard focus ring bug fix and its use around every call to -[NSButtonCell drawWithFrame:inView:]. You've indicated that you've verified that all the bugs those were workarounds for now work fine with ThemeMac (no, I have no idea what that default button cell one is). So this LGTM!
James Robinson
Comment 3 2012-08-16 16:57:16 PDT
Comment on attachment 158929 [details] Patch Okiedokie
WebKit Review Bot
Comment 4 2012-08-16 17:10:42 PDT
Comment on attachment 158929 [details] Patch Clearing flags on attachment: 158929 Committed r125830: <http://trac.webkit.org/changeset/125830>
WebKit Review Bot
Comment 5 2012-08-16 17:10:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.