Bug 94260 - Delete ThemeChromiumMac, use ThemeMac in chromium/mac instead
Summary: Delete ThemeChromiumMac, use ThemeMac in chromium/mac instead
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nico Weber
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-16 15:42 PDT by Nico Weber
Modified: 2012-08-16 17:10 PDT (History)
2 users (show)

See Also:

Attachments
Patch (40.07 KB, patch)
2012-08-16 15:45 PDT, Nico Weber 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2012-08-16 15:42:12 PDT 
Delete ThemeChromiumMac, use ThemeMac in chromium/mac instead
Comment 1 Nico Weber 2012-08-16 15:45:37 PDT 
Created attachment 158929 [details]
Patch
Comment 2 Avi Drissman 2012-08-16 16:12:31 PDT 
The original fork notes the changes:

- The import of FlippedView() and its use as the parent view for cell
   rendering.
 - In updateStates() the code to update the cells' inactive state.
 - In paintButton() the code to save/restore the window's default button cell.
 - The Snow Leopard focus ring bug fix and its use around every call to
   -[NSButtonCell drawWithFrame:inView:].

You've indicated that you've verified that all the bugs those were workarounds for now work fine with ThemeMac (no, I have no idea what that default button cell one is). So this LGTM!
Comment 3 James Robinson 2012-08-16 16:57:16 PDT 
Comment on attachment 158929 [details]
Patch

Okiedokie
Comment 4 WebKit Review Bot 2012-08-16 17:10:42 PDT 
Comment on attachment 158929 [details]
Patch

Clearing flags on attachment: 158929

Committed r125830: <http://trac.webkit.org/changeset/125830>
Comment 5 WebKit Review Bot 2012-08-16 17:10:45 PDT 
All reviewed patches have been landed.  Closing bug.