Bug 94249 - [BlackBerry] Changes resulting from moving application directory methods from platform client to platform settings.
Summary: [BlackBerry] Changes resulting from moving application directory methods from...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-16 13:37 PDT by Parth Patel
Modified: 2012-08-24 10:12 PDT (History)
5 users (show)

See Also:

Attachments
webkit patch for changes in response to application directories methods moved from BlackBerryPlatformClient to BlackBerryPlatformSettings (12.02 KB, patch)
2012-08-16 13:37 PDT, Parth Patel 		no flags Details | Formatted Diff | Diff
Patch (14.96 KB, patch)
2012-08-23 07:36 PDT, Parth Patel 		no flags Details | Formatted Diff | Diff
Patch (14.88 KB, patch)
2012-08-23 08:09 PDT, Parth Patel 		no flags Details | Formatted Diff | Diff
Patch (13.20 KB, patch)
2012-08-23 10:51 PDT, Parth Patel 		no flags Details | Formatted Diff | Diff
Patch (2.62 KB, patch)
2012-08-23 11:19 PDT, Parth Patel 		no flags Details | Formatted Diff | Diff
Patch (11.93 KB, patch)
2012-08-24 08:31 PDT, Parth Patel 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Parth Patel 2012-08-16 13:37:26 PDT 
Created attachment 158890 [details]
webkit patch for changes in response to application directories methods moved from BlackBerryPlatformClient to BlackBerryPlatformSettings

Changes in response to Application Directory methods moved from class BlackBerryPlatformClient to BlackBerryPlatformSettings in platform respository since these methods are more appropriate in class BlackBerryPlatformSettings.
Comment 1 Rob Buis 2012-08-16 13:51:09 PDT 
Comment on attachment 158890 [details]
webkit patch for changes in response to application directories methods moved from BlackBerryPlatformClient to BlackBerryPlatformSettings

This needs a ChangeLog!
Comment 2 Parth Patel 2012-08-23 07:36:05 PDT 
Created attachment 160159 [details]
Patch
Comment 3 Parth Patel 2012-08-23 08:09:44 PDT 
Created attachment 160165 [details]
Patch
Comment 4 Parth Patel 2012-08-23 10:51:03 PDT 
Created attachment 160194 [details]
Patch
Comment 5 Parth Patel 2012-08-23 11:19:36 PDT 
Created attachment 160199 [details]
Patch
Comment 6 Parth Patel 2012-08-24 08:31:20 PDT 
Created attachment 160424 [details]
Patch
Comment 7 Rob Buis 2012-08-24 09:27:39 PDT 
Comment on attachment 160424 [details]
Patch

LGTM.
Comment 8 WebKit Review Bot 2012-08-24 10:12:37 PDT 
Comment on attachment 160424 [details]
Patch

Clearing flags on attachment: 160424

Committed r126596: <http://trac.webkit.org/changeset/126596>
Comment 9 WebKit Review Bot 2012-08-24 10:12:41 PDT 
All reviewed patches have been landed.  Closing bug.