RESOLVED FIXED 94241
Frame bytes should be determined by platform image decoder 
https://bugs.webkit.org/show_bug.cgi?id=94241
Summary Frame bytes should be determined by platform image decoder
Hin-Chung Lam
Reported 2012-08-16 12:56:10 PDT
BitmapImage assumes the cached size is always width * height * 4. For platforms that implement deferred image decoding or have platform image backed by a texture would use no system memory. For these cases it is best to query the platform image decoder to determine the frame size such that these frames are not managed by WebKit's memory cached.
Attachments
Patch (11.30 KB, patch)
2012-08-16 15:04 PDT, Hin-Chung Lam 		no flags
DetailsFormatted DiffDiff
Patch (11.21 KB, patch)
2012-08-16 15:07 PDT, Hin-Chung Lam 		no flags
DetailsFormatted DiffDiff
Patch (11.61 KB, patch)
2012-08-16 18:26 PDT, Hin-Chung Lam 		no flags
DetailsFormatted DiffDiff
Patch (11.62 KB, patch)
2012-08-20 13:00 PDT, Hin-Chung Lam 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Hin-Chung Lam
Comment 1 2012-08-16 15:04:22 PDT
Created attachment 158914 [details] Patch
Hin-Chung Lam
Comment 2 2012-08-16 15:07:59 PDT
Created attachment 158917 [details] Patch
Build Bot
Comment 3 2012-08-16 16:26:02 PDT
Comment on attachment 158917 [details] Patch Attachment 158917 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/13514553
Hin-Chung Lam
Comment 4 2012-08-16 18:26:11 PDT
Created attachment 158966 [details] Patch
Dongseong Hwang
Comment 5 2012-08-17 00:04:36 PDT
(In reply to comment #4) > Created an attachment (id=158966) [details] > Patch > Source/WebCore/platform/image-decoders/ImageDecoder.cpp > 294 return m_size.width() * m_size.height() * 4; You can use IntSize::area(). How about m_size.area() * sizeof(PixelData)?
Hin-Chung Lam
Comment 6 2012-08-20 13:00:25 PDT
Created attachment 159497 [details] Patch
WebKit Review Bot
Comment 7 2012-08-28 10:48:17 PDT
Comment on attachment 159497 [details] Patch Clearing flags on attachment: 159497 Committed r126892: <http://trac.webkit.org/changeset/126892>
WebKit Review Bot
Comment 8 2012-08-28 10:48:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.