Bug 94231 - Web Inspector: enhance external test-runner and add cleanup code
Summary: Web Inspector: enhance external test-runner and add cleanup code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-16 11:17 PDT by johnjbarton
Modified: 2012-08-17 06:00 PDT (History)
11 users (show)

See Also:

Attachments
Patch (7.62 KB, patch)
2012-08-16 11:21 PDT, johnjbarton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description johnjbarton 2012-08-16 11:17:35 PDT 
test-runner.html:
add 'click on test result to select for next run' feature.
remember the users size for the inspector popup.
refactor server URLs to one location at top of file.
use the same value for both tests and scanner servers.
remove one extra instruction on the page.
refactor clean up code.
close the two popup windows if the test-runner.html is reloaded.
Comment 1 johnjbarton 2012-08-16 11:21:22 PDT 
Created attachment 158857 [details]
Patch
Comment 2 Pavel Feldman 2012-08-16 11:42:34 PDT 
Comment on attachment 158857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158857&action=review

> Source/WebCore/inspector/front-end/test-runner.html:206
> +        if (actual === this._expected || actual === this._expected + "\n") {

This fuzziness does not harm until we start creating expectations.
Comment 3 WebKit Review Bot 2012-08-17 06:00:16 PDT 
Comment on attachment 158857 [details]
Patch

Clearing flags on attachment: 158857

Committed r125889: <http://trac.webkit.org/changeset/125889>
Comment 4 WebKit Review Bot 2012-08-17 06:00:21 PDT 
All reviewed patches have been landed.  Closing bug.