Bug 94216 – View source doesn't interpret escape characters in hrefs.

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Anthony Berent]

Originally reported against Chromium as issue 46737.

" Chrome Version       : 5.0.375.55 (Official Build 47796) beta

What steps will reproduce the problem?
1. Open the attached testcase
2. hit ctrl-u for view-source
3. click the href

What is the expected result?
New tab should open at test.html?a&b

What happens instead?
Tab opens at test.html?a&b"

This is still an issue in all Webkit based browsers (see the Chromium bug for history.).

[Anthony Berent]

Created attachment 158802 [details]
Test file demonstrating bug

[Anthony Berent]

Created attachment 158817 [details]
Patch

[Hans Wennborg]

Comment on attachment 158817 [details]
Patch

Thanks! This seems to work nicely. I only have a tiny nit below.

View in context: https://bugs.webkit.org/attachment.cgi?id=158817&action=review

> Source/WebCore/html/HTMLViewSourceDocument.cpp:265
> +int HTMLViewSourceDocument::addRange(const String& source, int start, int end, const String& className, bool isLink, bool isAnchor, const String & link)

nit: the & should be attached to the type, i.e. "const String& link"

[Hans Wennborg]

Maybe Adam can review this, or point us towards someone who can.

[Adam Barth]

Comment on attachment 158817 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158817&action=review

Thanks!  Let's clean up the nits and then we'll be all set.

> Source/WebCore/html/HTMLViewSourceDocument.h:61
> -    int addRange(const String& source, int start, int end, const String& className, bool isLink = false, bool isAnchor = false);
> +    int addRange(const String& source, int start, int end, const String& className, bool isLink = false, bool isAnchor = false, const String& link = "");

nit: const String& link = String()

This avoids a malloc by using a null string rather than an empty string.

[Anthony Berent]

Created attachment 159061 [details]
Patch - handle escape chars in view source hrefs.

[Anthony Berent]

Created attachment 159062 [details]
Patch - handle escape chars in view source hrefs.

[WebKit Review Bot]

Comment on attachment 159062 [details]
Patch - handle escape chars in view source hrefs.

Clearing flags on attachment: 159062

Committed r125878: <http://trac.webkit.org/changeset/125878>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.