RESOLVED FIXED 94207
DirectoryEntry should use Dictionary rather than custom bindings code 
https://bugs.webkit.org/show_bug.cgi?id=94207
Summary DirectoryEntry should use Dictionary rather than custom bindings code
Adam Barth
Reported 2012-08-16 01:54:34 PDT
DirectoryEntry should use Dictionary rather than custom bindings code
Attachments
work in progress (33.00 KB, patch)
2012-08-16 01:56 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
work in progress (32.95 KB, patch)
2012-08-16 01:57 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (65.77 KB, patch)
2012-08-16 11:49 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-08-16 01:56:02 PDT
Created attachment 158752 [details] work in progress
Adam Barth
Comment 2 2012-08-16 01:57:22 PDT
Created attachment 158753 [details] work in progress
WebKit Review Bot
Comment 3 2012-08-16 02:40:48 PDT
Attachment 158753 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/Modules/filesystem/WebKitFlags.h:31: #ifndef header guard has wrong style, please use: WebKitFlags_h [build/header_guard] [5] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Peter Beverloo (cr-android ews)
Comment 4 2012-08-16 02:48:29 PDT
Comment on attachment 158753 [details] work in progress Attachment 158753 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13504920
Eric Seidel (no email)
Comment 5 2012-08-16 02:53:29 PDT
Sorry, I made a mess of your bug. :(
WebKit Review Bot
Comment 6 2012-08-16 02:59:12 PDT
Comment on attachment 158753 [details] work in progress Attachment 158753 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13516315
Adam Barth
Comment 7 2012-08-16 09:40:57 PDT
> Sorry, I made a mess of your bug. :( It's ok. Yeah, this patch isn't done. I just wanted to post it before heading to bed do I didn't lose it.
Adam Barth
Comment 8 2012-08-16 11:49:11 PDT
Created attachment 158866 [details] Patch
Eric Seidel (no email)
Comment 9 2012-08-16 13:26:46 PDT
Comment on attachment 158866 [details] Patch LGTM.
WebKit Review Bot
Comment 10 2012-08-16 13:44:54 PDT
Comment on attachment 158866 [details] Patch Clearing flags on attachment: 158866 Committed r125807: <http://trac.webkit.org/changeset/125807>
WebKit Review Bot
Comment 11 2012-08-16 13:45:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.