DirectoryEntry should use Dictionary rather than custom bindings code
Created attachment 158752 [details] work in progress
Created attachment 158753 [details] work in progress
Attachment 158753 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/Modules/filesystem/WebKitFlags.h:31: #ifndef header guard has wrong style, please use: WebKitFlags_h [build/header_guard] [5] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 158753 [details] work in progress Attachment 158753 [details] did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13504920
Sorry, I made a mess of your bug. :(
Comment on attachment 158753 [details] work in progress Attachment 158753 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13516315
> Sorry, I made a mess of your bug. :( It's ok. Yeah, this patch isn't done. I just wanted to post it before heading to bed do I didn't lose it.
Created attachment 158866 [details] Patch
Comment on attachment 158866 [details] Patch LGTM.
Comment on attachment 158866 [details] Patch Clearing flags on attachment: 158866 Committed r125807: <http://trac.webkit.org/changeset/125807>
All reviewed patches have been landed. Closing bug.