Bug 94185 - Use initialization from literals for StringStatics
Summary: Use initialization from literals for StringStatics
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-15 21:43 PDT by Benjamin Poulain
Modified: 2012-08-16 12:28 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.29 KB, patch)
2012-08-15 22:15 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-08-15 21:43:29 PDT 
Use initialization from literals for StringStatics
Comment 1 Benjamin Poulain 2012-08-15 22:15:15 PDT 
Created attachment 158710 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-15 22:18:16 PDT 
Attachment 158710 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/te..." exit_code: 1
Source/WTF/wtf/text/StringStatics.cpp:56:  DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WTF/wtf/text/StringStatics.cpp:57:  DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WTF/wtf/text/StringStatics.cpp:58:  DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WTF/wtf/text/StringStatics.cpp:59:  DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WTF/wtf/text/StringStatics.cpp:60:  DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WTF/wtf/text/StringStatics.cpp:61:  DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Source/WTF/wtf/text/StringStatics.cpp:62:  DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 7 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Geoffrey Garen 2012-08-15 22:20:24 PDT 
Comment on attachment 158710 [details]
Patch

r=me
Comment 4 Benjamin Poulain 2012-08-16 12:28:34 PDT 
Comment on attachment 158710 [details]
Patch

Clearing flags on attachment: 158710

Committed r125797: <http://trac.webkit.org/changeset/125797>
Comment 5 Benjamin Poulain 2012-08-16 12:28:36 PDT 
All reviewed patches have been landed.  Closing bug.