RESOLVED FIXED94185
Use initialization from literals for StringStatics 
https://bugs.webkit.org/show_bug.cgi?id=94185
Summary Use initialization from literals for StringStatics
Benjamin Poulain
Reported 2012-08-15 21:43:29 PDT
Use initialization from literals for StringStatics
Attachments
Patch (3.29 KB, patch)
2012-08-15 22:15 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-08-15 22:15:15 PDT
Created attachment 158710 [details] Patch
WebKit Review Bot
Comment 2 2012-08-15 22:18:16 PDT
Attachment 158710 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/te..." exit_code: 1 Source/WTF/wtf/text/StringStatics.cpp:56: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/text/StringStatics.cpp:57: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/text/StringStatics.cpp:58: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/text/StringStatics.cpp:59: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/text/StringStatics.cpp:60: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/text/StringStatics.cpp:61: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Source/WTF/wtf/text/StringStatics.cpp:62: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4] Total errors found: 7 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2012-08-15 22:20:24 PDT
Comment on attachment 158710 [details] Patch r=me
Benjamin Poulain
Comment 4 2012-08-16 12:28:34 PDT
Comment on attachment 158710 [details] Patch Clearing flags on attachment: 158710 Committed r125797: <http://trac.webkit.org/changeset/125797>
Benjamin Poulain
Comment 5 2012-08-16 12:28:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.