Bug 94183 - [chromium] Remove alwaysReserveTextures code - it doesn't do anything
Summary: [chromium] Remove alwaysReserveTextures code - it doesn't do anything
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Robinson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-15 21:06 PDT by James Robinson
Modified: 2012-08-16 10:16 PDT (History)
7 users (show)

See Also:

Attachments
Patch (7.39 KB, patch)
2012-08-15 21:08 PDT, James Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description James Robinson 2012-08-15 21:06:54 PDT 
[chromium] Remove alwaysReserveTextures code - it doesn't do anything
Comment 1 James Robinson 2012-08-15 21:08:25 PDT 
Created attachment 158704 [details]
Patch
Comment 2 James Robinson 2012-08-15 21:09:54 PDT 
This code appears dead by inspector.  Out, out vile jelly!

With this gone I think I can also remove a lot of (all of?) the WebLayer tree walking API, but I'll do that separately since I want to look closely at the unit tests for that to make sure we don't lose any useful coverage.
Comment 3 WebKit Review Bot 2012-08-15 21:10:01 PDT 
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 4 Adrienne Walker 2012-08-16 09:34:08 PDT 
Thanks for cleaning this up.  I wonder if it was the texture manager refactoring that got rid of this flag having any effect.
Comment 5 James Robinson 2012-08-16 10:16:18 PDT 
Comment on attachment 158704 [details]
Patch

Clearing flags on attachment: 158704

Committed r125788: <http://trac.webkit.org/changeset/125788>
Comment 6 James Robinson 2012-08-16 10:16:22 PDT 
All reviewed patches have been landed.  Closing bug.