RESOLVED FIXED 94183
[chromium] Remove alwaysReserveTextures code - it doesn't do anything 
https://bugs.webkit.org/show_bug.cgi?id=94183
Summary [chromium] Remove alwaysReserveTextures code - it doesn't do anything
James Robinson
Reported 2012-08-15 21:06:54 PDT
[chromium] Remove alwaysReserveTextures code - it doesn't do anything
Attachments
Patch (7.39 KB, patch)
2012-08-15 21:08 PDT, James Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2012-08-15 21:08:25 PDT
Created attachment 158704 [details] Patch
James Robinson
Comment 2 2012-08-15 21:09:54 PDT
This code appears dead by inspector. Out, out vile jelly! With this gone I think I can also remove a lot of (all of?) the WebLayer tree walking API, but I'll do that separately since I want to look closely at the unit tests for that to make sure we don't lose any useful coverage.
WebKit Review Bot
Comment 3 2012-08-15 21:10:01 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Adrienne Walker
Comment 4 2012-08-16 09:34:08 PDT
Thanks for cleaning this up. I wonder if it was the texture manager refactoring that got rid of this flag having any effect.
James Robinson
Comment 5 2012-08-16 10:16:18 PDT
Comment on attachment 158704 [details] Patch Clearing flags on attachment: 158704 Committed r125788: <http://trac.webkit.org/changeset/125788>
James Robinson
Comment 6 2012-08-16 10:16:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.