Bug 94180 - TextureMapperGL::beginPainting has a duplicate call to get GL_FRAMEBUFFER_BINDING.
Summary: TextureMapperGL::beginPainting has a duplicate call to get GL_FRAMEBUFFER_BIN...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-15 20:36 PDT by Zhigang Gong
Modified: 2012-08-16 00:19 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.73 KB, patch)
2012-08-15 20:37 PDT, Zhigang Gong
no flags Details | Formatted Diff | Diff
Patch (1.54 KB, patch)
2012-08-15 23:00 PDT, Zhigang Gong
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zhigang Gong 2012-08-15 20:36:53 PDT
TextureMapperGL::beginPainting has a duplicate call to get GL_FRAMEBUFFER_BINDING.
Comment 1 Zhigang Gong 2012-08-15 20:37:30 PDT
Created attachment 158701 [details]
Patch
Comment 2 WebKit Review Bot 2012-08-15 22:46:41 PDT
Comment on attachment 158701 [details]
Patch

Rejecting attachment 158701 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
Kit/chromium/third_party/yasm/source/patched-yasm --revision 134927 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
50>At revision 134927.

________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/13511425
Comment 3 Zhigang Gong 2012-08-15 23:00:23 PDT
Created attachment 158715 [details]
Patch
Comment 4 WebKit Review Bot 2012-08-15 23:08:41 PDT
Comment on attachment 158715 [details]
Patch

Rejecting attachment 158715 [details] from commit-queue.

zhigang.gong@gmail.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 5 Zhigang Gong 2012-08-15 23:19:24 PDT
Hi Noam,

As the previous patch has OOPS and caused the build fail, I resubmitted a new version, Could you help to review the new version again. Thanks.
Comment 6 WebKit Review Bot 2012-08-16 00:19:01 PDT
Comment on attachment 158715 [details]
Patch

Clearing flags on attachment: 158715

Committed r125752: <http://trac.webkit.org/changeset/125752>
Comment 7 WebKit Review Bot 2012-08-16 00:19:04 PDT
All reviewed patches have been landed.  Closing bug.