Bug 94176 – [BlackBerry] Some media controls are mispositioned for dynamic live streams (HLS)

• Status: CLOSED
• Resolution: FIXED
• Component: WebKit BlackBerry

[Max Feil]

The default HTML5 media controls for dynamic live streams have no timeline or timeline container, which for BlackBerry results in mispositioning of the buttons that are supposed to be to the right of the timeline (fullscreen and mute). Instead of being right justified they incorrectly appear right next to the play button. The fix is to explicitly position these 2 buttons whenever the media duration is infinite (indicating a live stream).

An automated layout test is not possible for this patch because dynamic live streams require a special dedicated web server. Putting an external video URL into an automated test is not correct either. So I have created a manual test that points to an external HLS video that works today.

[Max Feil]

Created attachment 158696 [details]
Patch

[Antonio Gomes]

Comment on attachment 158696 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158696&action=review

r+

I have one comment. Feel free to address it or not. If you do, please reupload the patch with pre-filled "Reviewed by Antonio Gomes" in the changelog and commit message, and just request cq? Thanks.

> Source/WebCore/platform/blackberry/RenderThemeBlackBerry.cpp:771
> +    Length zero(0, Fixed);

I would have defined "zero" within the if where it is used.

[Max Feil]

Comment on attachment 158696 [details]
Patch

I think it's cleaner to declare "zero" with all the other Length values. That way they are all grouped together, and can be freely re-used anywhere in the function in the future.

[WebKit Review Bot]

Comment on attachment 158696 [details]
Patch

Clearing flags on attachment: 158696

Committed r125811: <http://trac.webkit.org/changeset/125811>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Max Feil]

Closing bug for patch that landed a long time ago.