WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
94160
Fix TestExpectations line format for two fast/css tests failing on mac
https://bugs.webkit.org/show_bug.cgi?id=94160
Summary
Fix TestExpectations line format for two fast/css tests failing on mac
Kiran Muppala
Reported
2012-08-15 17:10:30 PDT
The failing tests are fast/css/word-spacing-characters.html and fast/css/word-spacing-characters-complex-text.html
http://build.webkit.org/results/Apple%20Lion%20Debug%20WK1%20(Tests)/r125583%20(1871)/results.html
The tests were added by the patch for
https://bugs.webkit.org/show_bug.cgi?id=89826
in
r125578
. The first build which has layout test results after that is 125583, hence it is not clear if the tests passed when checked in or not.
Attachments
Patch
(1.55 KB, patch)
2012-08-15 18:09 PDT
,
Kiran Muppala
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Kiran Muppala
Comment 1
2012-08-15 17:30:31 PDT
Looking into platform/mac/TestExpectations showed that these tests were already added as expected failures. But the "MAC" configuration modifier in the test expectations line is causing them to be ignored. // Added by
bug 89826
BUGWK94008 MAC : fast/css/word-spacing-characters.html = IMAGE BUGWK94003 MAC : fast/css/word-spacing-characters-complex-text.html = IMAGE Removing the "MAC" modifier, causes the lines to take effect and the tests are skipped.
Kiran Muppala
Comment 2
2012-08-15 18:09:31 PDT
Created
attachment 158675
[details]
Patch
WebKit Review Bot
Comment 3
2012-08-15 18:48:34 PDT
Comment on
attachment 158675
[details]
Patch Clearing flags on attachment: 158675 Committed
r125735
: <
http://trac.webkit.org/changeset/125735
>
WebKit Review Bot
Comment 4
2012-08-15 18:48:37 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug