Bug 94154 - [chromium] Replace destRect with destOffset in texture upload
Summary: [chromium] Replace destRect with destOffset in texture upload
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexandre Elias
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-15 15:19 PDT by Alexandre Elias
Modified: 2012-08-16 16:43 PDT (History)
11 users (show)

See Also:

Attachments
Patch (44.43 KB, patch)
2012-08-15 15:24 PDT, Alexandre Elias 		no flags Details | Formatted Diff | Diff
Patch (45.70 KB, patch)
2012-08-15 16:59 PDT, Alexandre Elias 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Elias 2012-08-15 15:19:09 PDT 
[chromium] Replace destRect with destOffset in texture upload
Comment 1 Alexandre Elias 2012-08-15 15:24:06 PDT 
Created attachment 158649 [details]
Patch
Comment 2 Alexandre Elias 2012-08-15 15:26:15 PDT 
This is just a small cleanup for a problem that I encountered while writing the software texture upload implementation.  I realized the GL implementation doesn't properly support destRect either, so we should just remove it from the interface.
Comment 3 James Robinson 2012-08-15 15:35:32 PDT 
Comment on attachment 158649 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=158649&action=review

> Source/WebCore/ChangeLog:13
> +        "IntRect destRect" by "IntPoint destOffset".

According to the WebCore geometry system, offsets should be represented by IntSize, not IntPoint.  Mind search-replacing the type before landing?
Comment 4 WebKit Review Bot 2012-08-15 15:51:36 PDT 
Comment on attachment 158649 [details]
Patch

Attachment 158649 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/13504733
Comment 5 Peter Beverloo (cr-android ews) 2012-08-15 16:35:52 PDT 
Comment on attachment 158649 [details]
Patch

Attachment 158649 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/13517141
Comment 6 Alexandre Elias 2012-08-15 16:59:00 PDT 
Created attachment 158663 [details]
Patch
Comment 7 Alexandre Elias 2012-08-15 16:59:47 PDT 
Done, although I'd suggest changing the policy during the transition to gfx:: types, since I don't think it makes any sense.
Comment 8 WebKit Review Bot 2012-08-16 16:43:45 PDT 
Comment on attachment 158663 [details]
Patch

Clearing flags on attachment: 158663

Committed r125827: <http://trac.webkit.org/changeset/125827>
Comment 9 WebKit Review Bot 2012-08-16 16:43:49 PDT 
All reviewed patches have been landed.  Closing bug.