Bug 94153 - [BlackBerry] WebPage::executeJavaScriptFunction will crash if there is an exception when compiled in debug
Summary: [BlackBerry] WebPage::executeJavaScriptFunction will crash if there is an exc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-08-15 14:50 PDT by Benjamin Meyer
Modified: 2012-08-15 16:35 PDT (History)
4 users (show)

See Also:

Attachments
patch (2.08 KB, patch)
2012-08-15 14:55 PDT, Benjamin Meyer 		yong.li.webkit: review+
Details | Formatted Diff | Diff
patch (2.09 KB, patch)
2012-08-15 15:06 PDT, Benjamin Meyer 		no flags Details | Formatted Diff | Diff
patch (1.75 KB, patch)
2012-08-15 15:12 PDT, Benjamin Meyer 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Meyer 2012-08-15 14:50:24 PDT 
Use WebPage::executeJavaScriptFunction to call a valid function that throws an exception.
Comment 1 Benjamin Meyer 2012-08-15 14:55:48 PDT 
Created attachment 158642 [details]
patch
Comment 2 Yong Li 2012-08-15 15:02:22 PDT 
Comment on attachment 158642 [details]
patch

R+ with the changelog changed to the same look as other commits.
Comment 3 Benjamin Meyer 2012-08-15 15:06:46 PDT 
Created attachment 158644 [details]
patch

added BLACKBERRY and swapped reviewed by and the url
Comment 4 WebKit Review Bot 2012-08-15 15:08:23 PDT 
Attachment 158644 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp',..." exit_code: 1
Source/WebKit/blackberry/ChangeLog:6:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Benjamin Meyer 2012-08-15 15:12:29 PDT 
Created attachment 158645 [details]
patch
Comment 6 Yong Li 2012-08-15 15:13:52 PDT 
Comment on attachment 158645 [details]
patch

Still different as others. Not sure why prepare-changeLog works differently for you. but OK...
Comment 7 WebKit Review Bot 2012-08-15 16:35:06 PDT 
Comment on attachment 158645 [details]
patch

Clearing flags on attachment: 158645

Committed r125721: <http://trac.webkit.org/changeset/125721>
Comment 8 WebKit Review Bot 2012-08-15 16:35:10 PDT 
All reviewed patches have been landed.  Closing bug.